[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17353 Please update PR description and title. LGTM pending Jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17353 **[Test build #74947 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74947/testReport)** for PR 17353 at commit [`af511b2`](https://github.com/apache/spark/commit/af511b281756da8a40af876a7c902bdf3388feb3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17353 **[Test build #74945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74945/testReport)** for PR 17353 at commit [`71459c5`](https://github.com/apache/spark/commit/71459c5280da2360ba6c5769a88b5ea95f8a9a13). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17353 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17353 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74934/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17353 **[Test build #74934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74934/testReport)** for PR 17353 at commit [`2a9ba46`](https://github.com/apache/spark/commit/2a9ba4651a0d46a27e494bf9dda4c444cf1f2831). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17353 **[Test build #74934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74934/testReport)** for PR 17353 at commit [`2a9ba46`](https://github.com/apache/spark/commit/2a9ba4651a0d46a27e494bf9dda4c444cf1f2831). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17353 Yeah. The counts can help us understand the pruning rate of the search space. When CBO join reordering is very slow, we can check the counts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/17353 debug log SGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/17353 Where should we check the count? Whom do we want to expose it to? How about a debug level log? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17353 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74864/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17353 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17353 **[Test build #74864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74864/testReport)** for PR 17353 at commit [`65b2b5b`](https://github.com/apache/spark/commit/65b2b5bb3bb73d582e935fdd1880cb64947c9f19). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17353 Does it make sense to introduce some counts to decide how many new JoinPlan we build? We can find out what we pruned in the search. It can easy for us to ensure no regression happened when we improve the codes in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17353 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74845/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17353 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17353 **[Test build #74845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74845/testReport)** for PR 17353 at commit [`7598eb8`](https://github.com/apache/spark/commit/7598eb81b782f71d9da3794a6a007c63fdf42b23). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class Cost(card: BigInt, size: BigInt) ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17353
Replace the following codes by using `pattern match`
```
if (joinPlan.isDefined) {
val newJoinPlan = joinPlan.get
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17353 Could we move the checking `if (oneSidePlan.itemIds.intersect(otherSidePlan.itemIds).isEmpty)` into the `buildJoin`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/17353 Could you also update the description of `object JoinReorderDP` based on the recent update in https://github.com/apache/spark/pull/17286? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17353 **[Test build #74845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74845/testReport)** for PR 17353 at commit [`7598eb8`](https://github.com/apache/spark/commit/7598eb81b782f71d9da3794a6a007c63fdf42b23). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17353: [SPARK-17080][SQL][FOLLOWUP] Improve documentation and n...
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/17353 cc @gatorsmile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
