[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18151 Merging with master, branch-2.2 Thanks for reviewing! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78262/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #78262 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78262/testReport)** for PR 18151 at commit [`5830186`](https://github.com/apache/spark/commit/58301861500fe1c6134d4dc8cf3e789d7b1cabc3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #78262 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78262/testReport)** for PR 18151 at commit [`5830186`](https://github.com/apache/spark/commit/58301861500fe1c6134d4dc8cf3e789d7b1cabc3). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user sethah commented on the issue: https://github.com/apache/spark/pull/18151 One minor comment, otherwise LGTM. Thanks for catching this @jkbradley! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18151 LGTM with that change. Seems odd we have to override `predict` and `raw2prediction` - seems this could be cleaned up perhaps via a better `transform` impl in `ClassificationModel`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77655/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77655/testReport)** for PR 18151 at commit [`851e0b6`](https://github.com/apache/spark/commit/851e0b679d36c34befcb80a84b0594d4b70f1f69). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77655/testReport)** for PR 18151 at commit [`851e0b6`](https://github.com/apache/spark/commit/851e0b679d36c34befcb80a84b0594d4b70f1f69). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77604/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77604/testReport)** for PR 18151 at commit [`35c13cf`](https://github.com/apache/spark/commit/35c13cf873ca000e30e4f91787fc9441372010ba). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77604 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77604/testReport)** for PR 18151 at commit [`35c13cf`](https://github.com/apache/spark/commit/35c13cf873ca000e30e4f91787fc9441372010ba). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18151 So...good thing you asked for the test b/c transform() wasn't going through the corrected code path. Another bit of evidence that the Prediction APIs don't generalize that well... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/18151 Good catch. Agree with @sethah comment about adding a test case, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77574/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77574/testReport)** for PR 18151 at commit [`98ffd16`](https://github.com/apache/spark/commit/98ffd16ffd53ff86c64629274e8d19cbc9860e0a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #3769 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3769/testReport)** for PR 18151 at commit [`98ffd16`](https://github.com/apache/spark/commit/98ffd16ffd53ff86c64629274e8d19cbc9860e0a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77574/testReport)** for PR 18151 at commit [`98ffd16`](https://github.com/apache/spark/commit/98ffd16ffd53ff86c64629274e8d19cbc9860e0a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77565/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18151 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77565 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77565/testReport)** for PR 18151 at commit [`5a612c3`](https://github.com/apache/spark/commit/5a612c3d9b417f559275006e45dae40e72653f6d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/18151 CC @mlnick @yanboliang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18151: [SPARK-20929][ML] LinearSVC should use its own threshold...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18151 **[Test build #77565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/77565/testReport)** for PR 18151 at commit [`5a612c3`](https://github.com/apache/spark/commit/5a612c3d9b417f559275006e45dae40e72653f6d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
