Github user aosagie commented on the issue:
https://github.com/apache/spark/pull/18499
Yes, I agree with @IngoSchuster
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user IngoSchuster commented on the issue:
https://github.com/apache/spark/pull/18499
Yes I believe it still makes sense to limit the number of selector threads.
Jetty's default is tuned for a real web server and by default it creates
(number of cpus / 2) selector threads.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18499
@aosagie do we still need the previous fix for SPARK-21176?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18499
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18499
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18499
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80355/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18499
**[Test build #80355 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80355/testReport)**
for PR 18499 at commit
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/18499
I don't see any code issues, but I'm confident enough in my proxy knowledge
to give this a "lgtm"
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18499
**[Test build #80355 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80355/testReport)**
for PR 18499 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18499
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18499
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18499
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80216/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18499
**[Test build #80216 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80216/testReport)**
for PR 18499 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18499
**[Test build #80216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80216/testReport)**
for PR 18499 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18499
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18499
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user aosagie commented on the issue:
https://github.com/apache/spark/pull/18499
Hey @ajbozarth. Any chance you could provide a review or some guidance on
anything I can do to make this PR more amenable?
---
If your project is set up for it, you can reply to this email and
Github user aosagie commented on the issue:
https://github.com/apache/spark/pull/18499
@cloud-fan Hi, I just pushed a change to up the selector threads from 1 to
8. Can I get a retest please?
@jiangxb1987 Sorry to bother, but is there anyone available to give
guidance on
Github user IngoSchuster commented on the issue:
https://github.com/apache/spark/pull/18499
You are right, a short moment of confusion - already deleted my comment...
;-)
Please disregard it
Regards,
Ingo Schuster
Tel: +49-(0)7031-16-5156
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18499
Surely math.max is correct? or else the value is always 1.
On Tue, Jul 4, 2017 at 3:28 PM IngoSchuster
wrote:
> Can we pull that also into 2.1.1? The
Github user IngoSchuster commented on the issue:
https://github.com/apache/spark/pull/18499
Can we pull that also into 2.1.1? The original code in JettyUtils to limit
the number of selector threads is actually wrong.
Instead of
` val numSelectors = math.max(1,
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18499
cc @sarutak @gengliangwang Could you look at this when you have time?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18499
cc @gurvindersingh Could you look at this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18499
cc @jiangxb1987
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18499
**[Test build #3831 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3831/testReport)**
for PR 18499 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18499
**[Test build #3831 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3831/testReport)**
for PR 18499 at commit
Github user aosagie commented on the issue:
https://github.com/apache/spark/pull/18499
Hi @cloud-fan,
Any reason the test results didn't get posted? Is there some step I need to
take?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18499
OK to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18499
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
29 matches
Mail list logo