[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18872 @ProtD this needs a JIRA or else needs to be linked to whatever one you opened, in the title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18872 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80533/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18872 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18872 **[Test build #80533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80533/testReport)** for PR 18872 at commit [`38da77d`](https://github.com/apache/spark/commit/38da77dda5edf82f33fc0702154ef3989bae559d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18872 **[Test build #80533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80533/testReport)** for PR 18872 at commit [`38da77d`](https://github.com/apache/spark/commit/38da77dda5edf82f33fc0702154ef3989bae559d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18872 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80508/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18872 **[Test build #80508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80508/testReport)** for PR 18872 at commit [`b86bb44`](https://github.com/apache/spark/commit/b86bb446581e057637e9639eeda5d046ce0b57fa). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18872 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18872 **[Test build #80508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80508/testReport)** for PR 18872 at commit [`b86bb44`](https://github.com/apache/spark/commit/b86bb446581e057637e9639eeda5d046ce0b57fa). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18872 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM (key not found: numFeatures)
Github user ProtD commented on the issue: https://github.com/apache/spark/pull/18872 I added the unit test, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM
Github user ProtD commented on the issue: https://github.com/apache/spark/pull/18872 To reproduce the bug on v2.2 and v2.3: ```scala import org.apache.spark.ml.linalg.Vectors val rawData = Seq((1.0, Vectors.sparse(3, Seq((0, 2.0), (1, 3.0, (4.0, Vectors.sparse(3, Seq((0, 5.0), (2, 6.0) val dfTemp = spark.sparkContext.parallelize(rawData).toDF("label", "features") dfTemp.coalesce(1).write.format("libsvm").save("...filename...") ``` This causes `java.util.NoSuchElementException: key not found: numFeatures`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM
Github user ProtD commented on the issue: https://github.com/apache/spark/pull/18872 @srowen It worked in v2.0, but was broken probably in v2.2.0 by b3d39620c563e5f6a32a4082aa3908e1009c17d2. Current unit tests check writing only for dataframes which were previously read from a LibSVM format, not general ones. (And I guess people don't write LibSVMs very often - that may be why nobody has reported it.) @WeichenXu123 Yes, good idea, will do it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18872 Better title please? See http://spark.apache.org/contributing.html How does this work at all now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18872: [MLlib] Fix writing LibSVM
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18872 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org