[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18909 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18909 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18909 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80598/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18909 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18909 **[Test build #80598 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80598/testReport)** for PR 18909 at commit [`4d04a41`](https://github.com/apache/spark/commit/4d04a4120ffa23cd9424dc4aa3301314b51a5d3d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user aokolnychyi commented on the issue: https://github.com/apache/spark/pull/18909 @gatorsmile sure, this PR is only about tests, I was just wondering what is planned regarding cross joins with inequality conditions. I borrowed several tests from PR #16762 and added additional ones. As I mentioned, there is a small overlap between the existing tests and proposed ones but they are defined at different levels. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18909 **[Test build #80598 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80598/testReport)** for PR 18909 at commit [`4d04a41`](https://github.com/apache/spark/commit/4d04a4120ffa23cd9424dc4aa3301314b51a5d3d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18909 @aokolnychyi That PR https://github.com/apache/spark/pull/16762 will not be merged. We follow the definition of [CROSS JOIN](http://docs.oracle.com/javadb/10.6.2.1/ref/rrefsqljcrossjoin.html). So far, in this PR, maybe we just add the missing test cases? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user aokolnychyi commented on the issue: https://github.com/apache/spark/pull/18909 @gatorsmile I took a look at both PRs. I quickly scanned PR #14866 and did not find tests for existence joins. Also, `SQLConf.CROSS_JOINS_ENABLED = true` is checked only for `left_outer`. So, the proposed tests slightly improve the coverage. PR #16762 checks everything from a different prospective than the proposed rules and has some unique scenarios compared to PR #14866. The main question that PR #16762 rises is about, for instance, inner joins with inequality conditions. As far as I understood, the ability to detect such cartesian products was the motivation to move the check away from the Optimizer. Is it still planned? Cannot this be also done by modifying the existing rule in the Optimizer? Currently, it only checks that there are conditions which reference to both sides. Instead, it can rely on equality predicates, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18909 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18909 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80497/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18909 **[Test build #80497 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80497/testReport)** for PR 18909 at commit [`98b54ca`](https://github.com/apache/spark/commit/98b54cad45b638515d36966a1e64955f4f1531d1). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class CheckCartesianProductsSuite extends PlanTest ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18909 @aokolnychyi Thank you! Could you compare the original PR and checks whether we miss any test case you added here? https://github.com/apache/spark/pull/14866 In addition, I also had a PR which is not merged. https://github.com/apache/spark/pull/16762 Maybe you also can use some test cases from that PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18909: [MINOR][SQL] Additional test case for CheckCartesianProd...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18909 **[Test build #80497 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80497/testReport)** for PR 18909 at commit [`98b54ca`](https://github.com/apache/spark/commit/98b54cad45b638515d36966a1e64955f4f1531d1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
