[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90677/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20504
  
**[Test build #90677 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90677/testReport)**
 for PR 20504 at commit 
[`6c6c394`](https://github.com/apache/spark/commit/6c6c394e8f137cc739e89832d910c33a7324cd55).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3257/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-05-16 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20504
  
**[Test build #90677 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90677/testReport)**
 for PR 20504 at commit 
[`6c6c394`](https://github.com/apache/spark/commit/6c6c394e8f137cc739e89832d910c33a7324cd55).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-11 Thread wangyum
Github user wangyum commented on the issue:

https://github.com/apache/spark/pull/20504
  
@gatorsmile


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread wangyum
Github user wangyum commented on the issue:

https://github.com/apache/spark/pull/20504
  
Thanks @hvanhovell , the major changes is `SQLQueryTestSuite.scala`:
```scala
   private def listTestCases(): Seq[TestCase] = {
 -listFilesRecursively(new File(inputFilePath)).map { file =>
 +listFilesRecursively(new File(inputFilePath)).flatMap { file =>
val resultFile = file.getAbsolutePath.replace(inputFilePath, 
goldenFilePath) + ".out"
val absPath = file.getAbsolutePath
val testCaseName = 
absPath.stripPrefix(inputFilePath).stripPrefix(File.separator)
 -  TestCase(testCaseName, absPath, resultFile)
 +  if (testCaseName.contains("typeCoercion")) {
 +TypeCoercionMode.values.map(_.toString).map { mode =>
 +  val fileNameWithMode = mode + File.separator + file.getName
 +  val newTestCaseName = testCaseName.replace(file.getName, 
fileNameWithMode)
 +  val newResultFile = resultFile.replace(file.getName, 
fileNameWithMode)
 +  TestCase(newTestCaseName, absPath, newResultFile, mode)
 +}.toSeq
 +  } else {
 +Seq(TestCase(testCaseName, absPath, resultFile))
 +  }
  }
```
For a [type coercion 
input](https://github.com/apache/spark/tree/v2.3.0-rc2/sql/core/src/test/resources/sql-tests/inputs/typeCoercion),
 two results are generated in  different mode(`default` and `hive`).

**For example**:
_input_: 

sql/core/src/test/resources/sql-tests/inputs/typeCoercion/binaryComparison.sql
_results_: 

sql/core/src/test/resources/sql-tests/results/typeCoercion/default/binaryComparison.sql.out

sql/core/src/test/resources/sql-tests/results/typeCoercion/hive/binaryComparison.sql.out




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread hvanhovell
Github user hvanhovell commented on the issue:

https://github.com/apache/spark/pull/20504
  
@wangyum this is a PR of 24K lines! How are we going to review this 
properly? Can you provide some guidelines (major changes etc)?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87054/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20504
  
**[Test build #87054 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87054/testReport)**
 for PR 20504 at commit 
[`41ba497`](https://github.com/apache/spark/commit/41ba497dfab50dfefb5e3e7e636fea47ff031a33).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/578/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20504
  
**[Test build #87054 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87054/testReport)**
 for PR 20504 at commit 
[`41ba497`](https://github.com/apache/spark/commit/41ba497dfab50dfefb5e3e7e636fea47ff031a33).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87052/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20504
  
**[Test build #87052 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87052/testReport)**
 for PR 20504 at commit 
[`dd8531d`](https://github.com/apache/spark/commit/dd8531dbf55e1cc05eaa4e09d9ff278e02595a9a).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support a...

2018-02-04 Thread wangyum
Github user wangyum commented on the issue:

https://github.com/apache/spark/pull/20504
  
After SPARK-21646, `hive/binaryComparison.sql.out`, 
`hive/decimalPrecision.sql.out` and `hive/promoteStrings.sql.out` seems like 
this: 
https://github.com/wangyum/spark/commit/927f6e86712ec4da4d58dbde2859b48520df3194


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support t...

2018-02-04 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/20504
  
**[Test build #87052 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87052/testReport)**
 for PR 20504 at commit 
[`dd8531d`](https://github.com/apache/spark/commit/dd8531dbf55e1cc05eaa4e09d9ff278e02595a9a).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support t...

2018-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/577/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20504: [SPARK-23332][SQL] Update SQLQueryTestSuite to support t...

2018-02-04 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20504
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org