[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20511 @dongjoon-hyun Could you add a test case for `ORC-285` in the Spark side? This sounds like a bug fix that impacts Spark? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20511 Thank you, @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20511 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87304/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20511 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20511 **[Test build #87304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87304/testReport)** for PR 20511 at commit [`5e45129`](https://github.com/apache/spark/commit/5e451294a1465f64739dda5d892ca3bdd808e6cf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20511 **[Test build #87304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87304/testReport)** for PR 20511 at commit [`5e45129`](https://github.com/apache/spark/commit/5e451294a1465f64739dda5d892ca3bdd808e6cf). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20511 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20511 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/790/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20511 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20511 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87297/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20511 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20511 **[Test build #87297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87297/testReport)** for PR 20511 at commit [`5e45129`](https://github.com/apache/spark/commit/5e451294a1465f64739dda5d892ca3bdd808e6cf). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20511 First of all, ORC 1.4.2 was very safe because it has only ORC-235 removing redundant dependencies. For ORC 1.4.3, the following five patches are included. 1. ORC-298 Move the benchmark code base to non-Apache repository 2. ORC-240 Fix warnings from Maven 3. ORC-217 Duplicate rat plugins in pom.xml The above three are trivial. 4. ORC-285 Empty vector batches of floats or doubles get java.io.EOFException 5. ORC-296 Work around HADOOP-15171; also fix stream contract (4) is only adding a workaround for `batchSize=0`. (5) may cause performance difference. In general, the patches look required, but I didn't run a full test against ORC 1.4.3. Only ORC-296 might cause some performance difference. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20511 @dongjoon-hyun Could you go over the list of the resolved JIRAs in ORC 1.4.2 and 1.4.3 that could cause the regressions? We need to know the impact and the risk. If possible, also added a test case in Spark to ensure the issue has been resolved after the upgrade? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20511 **[Test build #87297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87297/testReport)** for PR 20511 at commit [`5e45129`](https://github.com/apache/spark/commit/5e451294a1465f64739dda5d892ca3bdd808e6cf). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20511 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20511: [SPARK-23340][BUILD] Update ORC to 1.4.3
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20511 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/783/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
