[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20590 thanks, merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20590 Hi, @cloud-fan and @gatorsmile . It's ready for review again. I think this definitely will reduce the flakiness for that suite. But, I'm still looking at some other places, too. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87425/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87425/testReport)** for PR 20590 at commit [`18c2485`](https://github.com/apache/spark/commit/18c248544d238bd3d5ff50f621f4c12b3efc430e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/874/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87425/testReport)** for PR 20590 at commit [`18c2485`](https://github.com/apache/spark/commit/18c248544d238bd3d5ff50f621f4c12b3efc430e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20590 The previous failures are flaky ones and irrelevant to this PR. - org.apache.spark.sql.FileBasedDataSourceSuite.(It is not a test it is a sbt.testing.SuiteSelector) - org.apache.spark.sql.streaming.StreamingOuterJoinSuite.right outer early state exclusion on left --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20590 Retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87402/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87402 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87402/testReport)** for PR 20590 at commit [`18c2485`](https://github.com/apache/spark/commit/18c248544d238bd3d5ff50f621f4c12b3efc430e). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87397/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87397 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87397/testReport)** for PR 20590 at commit [`5a9fa0b`](https://github.com/apache/spark/commit/5a9fa0b310f490ff5d99f212d92635bf2660eb48). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87402 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87402/testReport)** for PR 20590 at commit [`18c2485`](https://github.com/apache/spark/commit/18c248544d238bd3d5ff50f621f4c12b3efc430e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/862/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87393/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87393/testReport)** for PR 20590 at commit [`d4cc32e`](https://github.com/apache/spark/commit/d4cc32e7614603a162f6719c5c72e3d72e57f404). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/859/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87397 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87397/testReport)** for PR 20590 at commit [`5a9fa0b`](https://github.com/apache/spark/commit/5a9fa0b310f490ff5d99f212d92635bf2660eb48). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/855/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87393/testReport)** for PR 20590 at commit [`d4cc32e`](https://github.com/apache/spark/commit/d4cc32e7614603a162f6719c5c72e3d72e57f404). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20590 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87385/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87385/testReport)** for PR 20590 at commit [`d4cc32e`](https://github.com/apache/spark/commit/d4cc32e7614603a162f6719c5c72e3d72e57f404). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87384/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87384 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87384/testReport)** for PR 20590 at commit [`3b8cb0a`](https://github.com/apache/spark/commit/3b8cb0a1def32924afd3e4b9e4fc702e1d53d36a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87385/testReport)** for PR 20590 at commit [`d4cc32e`](https://github.com/apache/spark/commit/d4cc32e7614603a162f6719c5c72e3d72e57f404). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/849/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/848/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87384/testReport)** for PR 20590 at commit [`3b8cb0a`](https://github.com/apache/spark/commit/3b8cb0a1def32924afd3e4b9e4fc702e1d53d36a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20590 Thank you for review, @viirya , @kiszk , @cloud-fan . Yep. I'm still trying to reproduce it by a test case. I'll inform you later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20590 I know it's hard to add a test, we need a malformed ORC file to make the reader fail midway. @dongjoon-hyun do you think it's possible to generate such a ORC file? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20590 looks reasonable. `batchReader.initBatch` throw `FileNotException`, and we enter `afterEach`, detect the file stream leak and fail. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20590 @dongjoon-hyun One question. Do you know which test case in `FileBasedDataSourceSuite` may cause this failure? Now, we are seeing a stack trace at `afterEach`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20590 Umm... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87349/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20590 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #20590: [SPARK-23399][SQL] Register a task completion listener f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20590 **[Test build #87349 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87349/testReport)** for PR 20590 at commit [`198f186`](https://github.com/apache/spark/commit/198f1861cfe4d2cd544cb3a09d3a271de1b656ab). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
