Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95560/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95560 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95560/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95560 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95560/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95550/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95550 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95550/testReport)**
for PR 20637 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
I see. Let me remove the change regarding `asNullable` from this PR. I will
create another PR after this PR is merged.
---
-
To
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20637
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95550 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95550/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20637
BTW there are so many kinds of bad UTs, we should clearly define the scope
when fixing it.
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20637
Now the topic becomes detecting bad UTs, instead of "Remove redundant null
checks".
Can we focus on "Remove redundant null checks" in this PR and send another
PR for detecting bad UTs?
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
Note that if we miss non-primitive type tests unfortunately, we can't
detect the bad UTs without `asNullable` because they won't throw any exceptions
but just use the default value.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20637
> If someone would unintentionally generate incorrect dataType, we must
detect the mistake by failing the test without an exception.
This is the part I don't agree with. If someone writes
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
We need to detect the correctly written test with a wrong result. Let us
think about the following `map_zip_with` without #22126.
In the following example, `map_zip_with` without #22126
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20637
can you give a concrete example of how this can detect incorrect results?
The removed test case only shows how we can detect a wrongly written test.
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
I believe we still need this change.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20637
with the test removed, do we still need this change?
https://github.com/apache/spark/pull/20637/files#diff-41747ec3f56901eb7bfb95d2a217e94dR226
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95479/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95479 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95479/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95479 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95479/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95205/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95205 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95205/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95205 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95205/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
@cloud-fan @mgaido91 Do you have any other comments on this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95109/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95109 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95109/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95109 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95109/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95044/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95044/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #95044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95044/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94973/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94973 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94973/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94973 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94973/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
cc @ueshin @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94904/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94904 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94904/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94904/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/20637
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94899/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94899 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94899/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94899 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94899/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94896/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94896/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94896/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94881/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94881 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94881/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94881 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94881/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94878/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94878/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94878/testReport)**
for PR 20637 at commit
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/20637
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94806/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94806 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94806/testReport)**
for PR 20637 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94806 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94806/testReport)**
for PR 20637 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20637
+1 for ^
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20637
> When spark.sql.fromJsonForceNullableSchema=false, I think that a test is
invalid to pass nullable=false in the corresponding schema to the missing field.
+1.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94539/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20637
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20637
**[Test build #94539 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94539/testReport)**
for PR 20637 at commit
1 - 100 of 133 matches
Mail list logo
