[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user squito commented on the issue: https://github.com/apache/spark/pull/20940 thanks, can you close this pull request now? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user edwinalu commented on the issue: https://github.com/apache/spark/pull/20940 @squito, it is really weird. I had some problems with the last sync with master, and it looks like some of the changes from master got added. I've opened a new pull request:

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user squito commented on the issue: https://github.com/apache/spark/pull/20940 @edwinalu the diff is really weird in github now -- can you merge in the latest master? Or if github is just confused, maybe close this and open a new PR. thanks ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user edwinalu commented on the issue: https://github.com/apache/spark/pull/20940 @rezsafi, thanks for reviewing. It would be better if the heartbeat wasn't tied to sampling frequency. Most likely users would want to sample more frequently, although this would also mean more

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user rezasafi commented on the issue: https://github.com/apache/spark/pull/20940 This generally looks good to me. I have some concerns about piggy backing memory info on heart-beats, since basically this will be a uniform sampling of memory info and it may make the heart-beat

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89789/ Test PASSed. ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89789 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89789/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89789 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89789/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user squito commented on the issue: https://github.com/apache/spark/pull/20940 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89758/ Test FAILed. ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89758/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89758 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89758/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user squito commented on the issue: https://github.com/apache/spark/pull/20940 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89746/ Test FAILed. ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89746 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89746/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89746 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89746/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89745/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89745/ Test FAILed. ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89745/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89697/ Test FAILed. ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89697 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89697/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89697 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89697/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20940 @edwinalu sorry it looks like there are conflicts, we would need to rebase --- - To unsubscribe, e-mail:

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20940 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user edwinalu commented on the issue: https://github.com/apache/spark/pull/20940 Could a committer please request a retest? It looks like the tests passed (https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89685/testReport/), and the failure occurs after

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89685/ Test FAILed. ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89685 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89685/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #89685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89685/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user squito commented on the issue: https://github.com/apache/spark/pull/20940 btw you mentioned that some of the issues were fixed, but I haven't seen any more changes, maybe you forgot to push the changes? ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88800/ Test PASSed. ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #88800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88800/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #88800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88800/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20940 @edwinalu please take a look https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88725/testReport --- - To

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88725/ Test FAILed. ---

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #88725 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88725/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20940 **[Test build #88725 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88725/testReport)** for PR 20940 at commit

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20940 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user edwinalu commented on the issue: https://github.com/apache/spark/pull/20940 Yes, thanks. From: UCB AMPLab Reply-To: apache/spark Date: Thursday, March 29, 2018 at 3:13 PM To: apache/spark

[GitHub] spark issue #20940: [SPARK-23429][CORE] Add executor memory metrics to heart...

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20940 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional