[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21643 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21643 LGTM except for one minor comment. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92353/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21643 **[Test build #92353 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92353/testReport)** for PR 21643 at commit [`a30de22`](https://github.com/apache/spark/commit/a30de22183cab3cde90fce6029cd03dfc5b5758a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92352/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21643 **[Test build #92352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92352/testReport)** for PR 21643 at commit [`083673c`](https://github.com/apache/spark/commit/083673c9a9f851fc40dc53b42754776fba5f100a). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/493/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21643 **[Test build #92353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92353/testReport)** for PR 21643 at commit [`a30de22`](https://github.com/apache/spark/commit/a30de22183cab3cde90fce6029cd03dfc5b5758a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21643 **[Test build #92352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92352/testReport)** for PR 21643 at commit [`083673c`](https://github.com/apache/spark/commit/083673c9a9f851fc40dc53b42754776fba5f100a). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/21643 Thanks for your comments, @MaxGekk @maropu @cloud-fan , I've tweaked the unit test case to address your comments. Please check it out again. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/492/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/21643 https://github.com/apache/spark/pull/21643#pullrequestreview-131977512 For all practical purposes, no, this change shouldn't break any use cases that we support; there could be use cases that we didn't intend to support that might break. In Spark SQL, SQL/DataFrame/Dataset operations are all type-checked, and the analyzer will strictly reject operations that involve incompatible types. Array types in Spark SQL are neither covariant nor contravariant, so e.g. `array` and `array` would be considered incompatible, and the analyzer would have rejected equality comparison between them in the first place. In all other cases, `GenericArrayData` is a Spark SQL internal type that shouldn't be used on the outside, and I don't think we ever intended to support direct access of this type from the outside. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92335/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21643 **[Test build #92335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92335/testReport)** for PR 21643 at commit [`d91b44a`](https://github.com/apache/spark/commit/d91b44accbe40b9879cda259912e3ca38759d716). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/479/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21643 **[Test build #92335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92335/testReport)** for PR 21643 at commit [`d91b44a`](https://github.com/apache/spark/commit/d91b44accbe40b9879cda259912e3ca38759d716). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
