[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view

2016-09-20 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r79752499 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -36,6 +36,7 @@ import

[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view

2016-09-20 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r79752478 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -142,8 +145,12 @@ class SessionCatalog( //

[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view

2016-09-20 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r79752423 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -142,8 +145,12 @@ class SessionCatalog( //

[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view

2016-09-20 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r79744373 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -111,7 +111,8 @@ statement | ALTER TABLE

[GitHub] spark pull request #14897: [SPARK-17338][SQL][WIP] add global temp view

2016-09-20 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14897#discussion_r79744336 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/ListTablesSuite.scala --- @@ -33,7 +33,7 @@ class ListTablesSuite extends QueryTest with