[GitHub] spark pull request #16103: [SPARK-18374][ML]Incorrect words in StopWords/eng...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/16103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16103: [SPARK-18374][ML]Incorrect words in StopWords/eng...

[hhbyyh]

Github user hhbyyh commented on a diff in the pull request:

https://github.com/apache/spark/pull/16103#discussion_r90765451
  
--- Diff: 
mllib/src/main/resources/org/apache/spark/ml/feature/stopwords/english.txt ---
@@ -149,5 +149,58 @@ shan
 shouldn
 wasn
 weren
-won
 wouldn
--- End diff --

I'm fine with both options, leaving them or removing them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16103: [SPARK-18374][ML]Incorrect words in StopWords/eng...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/16103#discussion_r90754782
  
--- Diff: 
mllib/src/main/resources/org/apache/spark/ml/feature/stopwords/english.txt ---
@@ -149,5 +149,58 @@ shan
 shouldn
 wasn
 weren
-won
 wouldn
--- End diff --

You would then remove the other stems like "wasn" "weren" etc right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #16103: [SPARK-18374][ML]Incorrect words in StopWords/eng...

[hhbyyh]

GitHub user hhbyyh opened a pull request:

https://github.com/apache/spark/pull/16103

[SPARK-18374][ML]Incorrect words in StopWords/english.txt

## What changes were proposed in this pull request?

Currently English stop words list in MLlib contains only the argumented 
words after removing all the apostrophes, so "wouldn't" become "wouldn" and 
"t". Yet by default Tokenizer and RegexTokenizer don't split on apostrophes or 
quotes.

Adding original form to stop words list to match the behavior of Tokenizer 
and StopwordsRemover. Also remove "won" from list.

see more discussion in the jira: 
https://issues.apache.org/jira/browse/SPARK-18374

## How was this patch tested?
existing ut



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hhbyyh/spark addstopwords

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/16103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16103


commit efeae8c8ab57ef77f9d8fd240e6ef9af626f947a
Author: Yuhao 
Date:   2016-11-30T23:38:52Z

add stop words




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org