[GitHub] spark pull request #18765: [SPARK-19720][CORE][BACKPORT-2.1] Redact sensitiv...
Github user dmvieira closed the pull request at: https://github.com/apache/spark/pull/18765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18765: [SPARK-19720][CORE][BACKPORT-2.1] Redact sensitiv...
Github user dmvieira commented on a diff in the pull request:
https://github.com/apache/spark/pull/18765#discussion_r131154059
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2571,6 +2572,23 @@ private[spark] object Utils extends Logging {
sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
}
}
+
+ private[util] val REDACTION_REPLACEMENT_TEXT = "*(redacted)"
+ private[util] val SECRET_REDACTION_PATTERN = "(?i)secret|password".r
--- End diff --
I did it work there... I tested here and UI and spark-submit already
working. I think you can close this pull request and focus on #18802
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18765: [SPARK-19720][CORE][BACKPORT-2.1] Redact sensitiv...
Github user dmvieira commented on a diff in the pull request:
https://github.com/apache/spark/pull/18765#discussion_r131036498
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2571,6 +2572,23 @@ private[spark] object Utils extends Logging {
sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
}
}
+
+ private[util] val REDACTION_REPLACEMENT_TEXT = "*(redacted)"
+ private[util] val SECRET_REDACTION_PATTERN = "(?i)secret|password".r
--- End diff --
I did PR but I don't know why Jenkins fail with access error... It sounds
like permission issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18765: [SPARK-19720][CORE][BACKPORT-2.1] Redact sensitiv...
Github user dmvieira commented on a diff in the pull request:
https://github.com/apache/spark/pull/18765#discussion_r130733138
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2571,6 +2572,23 @@ private[spark] object Utils extends Logging {
sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
}
}
+
+ private[util] val REDACTION_REPLACEMENT_TEXT = "*(redacted)"
+ private[util] val SECRET_REDACTION_PATTERN = "(?i)secret|password".r
--- End diff --
I did another pull request with all feature:
https://github.com/apache/spark/pull/18802
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18765: [SPARK-19720][CORE][BACKPORT-2.1] Redact sensitiv...
Github user dmvieira commented on a diff in the pull request:
https://github.com/apache/spark/pull/18765#discussion_r130676428
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2571,6 +2572,23 @@ private[spark] object Utils extends Logging {
sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
}
}
+
+ private[util] val REDACTION_REPLACEMENT_TEXT = "*(redacted)"
+ private[util] val SECRET_REDACTION_PATTERN = "(?i)secret|password".r
--- End diff --
Hi @markgrover ! My intention here was only fix this security breach making
spark-submit redact patten similar to UI redact pattern. I can change it, but
it will be a new feature backport and not a bugfix backport
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18765: [SPARK-19720][CORE][BACKPORT-2.1] Redact sensitiv...
Github user markgrover commented on a diff in the pull request:
https://github.com/apache/spark/pull/18765#discussion_r130668429
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2571,6 +2572,23 @@ private[spark] object Utils extends Logging {
sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
}
}
+
+ private[util] val REDACTION_REPLACEMENT_TEXT = "*(redacted)"
+ private[util] val SECRET_REDACTION_PATTERN = "(?i)secret|password".r
--- End diff --
I think what's really happening here is that we are backporting some
changes introduced in SPARK-18535 while backporting this JIRA (SPARK-19720).
SPARK-18535 is a dependency of this, so if we want to backport this, we should
really be backporting SPARK-18535 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18765: [SPARK-19720][CORE][BACKPORT-2.1] Redact sensitiv...
Github user dmvieira commented on a diff in the pull request:
https://github.com/apache/spark/pull/18765#discussion_r130572412
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2571,6 +2572,23 @@ private[spark] object Utils extends Logging {
sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
}
}
+
+ private[util] val REDACTION_REPLACEMENT_TEXT = "*(redacted)"
+ private[util] val SECRET_REDACTION_PATTERN = "(?i)secret|password".r
--- End diff --
But I'm following UI logic at spark 2.1 version:
https://github.com/apache/spark/blob/branch-2.1/core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #18765: [SPARK-19720][CORE][BACKPORT-2.1] Redact sensitiv...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18765#discussion_r130513976
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2571,6 +2572,23 @@ private[spark] object Utils extends Logging {
sparkJars.map(_.split(",")).map(_.filter(_.nonEmpty)).toSeq.flatten
}
}
+
+ private[util] val REDACTION_REPLACEMENT_TEXT = "*(redacted)"
+ private[util] val SECRET_REDACTION_PATTERN = "(?i)secret|password".r
--- End diff --
This should be a configurable SQLConf.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
