Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18849
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r134038745
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r134029768
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r134029245
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r134027875
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r134000329
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133999734
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133899594
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133236830
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133236101
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -342,6 +359,12 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133135343
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133134774
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -342,6 +359,12 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133134000
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -342,6 +359,12 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133133656
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -288,6 +303,7 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132751607
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132530396
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132527085
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/Hive_2_1_DDLSuite.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132526607
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/Hive_2_1_DDLSuite.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132525593
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/Hive_2_1_DDLSuite.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132250345
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132249235
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/Hive_2_1_DDLSuite.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132107646
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/Hive_2_1_DDLSuite.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132088495
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132087575
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -908,7 +909,13 @@ private[hive] object HiveClientImpl {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132071898
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/Hive_2_1_DDLSuite.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132061177
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/Hive_2_1_DDLSuite.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132060765
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -908,7 +909,13 @@ private[hive] object HiveClientImpl {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132060528
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,41 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132059925
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -908,7 +909,13 @@ private[hive] object HiveClientImpl {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132058727
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -35,7 +35,7 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132058586
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1193,6 +1242,7 @@ object HiveExternalCatalog {
val
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132027648
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,39 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132027248
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,39 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132012867
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,39 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132012423
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1998,3 +2001,61 @@ class HiveDDLSuite
}
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r131894824
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -2356,18 +2356,9 @@ abstract class DDLSuite extends
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r131750071
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,39 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r131730515
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,39 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r131727081
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,39 @@ private[spark] class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r131700138
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,39 @@ private[spark] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r131516698
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -611,21 +640,39 @@ private[spark] class
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r131504834
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -908,7 +909,13 @@ private[hive] object HiveClientImpl {
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/18849
[SPARK-21617][SQL] Store correct table metadata when altering schema in
Hive metastore.
HiveExternalCatalog.alterTableSchema takes a shortcut by modifying the raw
Hive table metadata instead of
43 matches
Mail list logo
