Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19627
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19627#discussion_r180874011
--- Diff: python/pyspark/ml/tuning.py ---
@@ -194,7 +195,8 @@ def _to_java_impl(self):
return java_estimator, java_epms, java_evaluator
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19627#discussion_r180862523
--- Diff: python/pyspark/ml/tuning.py ---
@@ -194,7 +195,8 @@ def _to_java_impl(self):
return java_estimator, java_epms, java_evaluator
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19627#discussion_r180876558
--- Diff: python/pyspark/ml/tests.py ---
@@ -1018,6 +1018,48 @@ def test_parallel_evaluation(self):
cvParallelModel = cv.fit(dataset)
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19627#discussion_r180610868
--- Diff: python/pyspark/ml/tests.py ---
@@ -1186,6 +1228,38 @@ def test_parallel_evaluation(self):
tvsParallelModel = tvs.fit(dataset)
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/19627#discussion_r180611695
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -157,6 +157,8 @@ def get$Name(self):
"TypeConverters.toInt"),
