Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20396
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r167846686
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +456,220 @@ private[evaluation] object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r167591614
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +456,220 @@ private[evaluation] object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r167590799
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +456,220 @@ private[evaluation] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r167581903
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +456,220 @@ private[evaluation] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r167582857
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +456,220 @@ private[evaluation] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164303084
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +453,220 @@ private[evaluation] object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164116722
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +453,220 @@ private[evaluation] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164112428
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/evaluation/ClusteringEvaluatorSuite.scala
---
@@ -66,16 +66,38 @@ class ClusteringEvaluatorSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164112835
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -111,6 +129,46 @@ object ClusteringEvaluator
}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164111780
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +460,220 @@ private[evaluation] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164112258
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +460,220 @@ private[evaluation] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164112193
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +453,220 @@ private[evaluation] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164111264
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -84,18 +81,39 @@ class ClusteringEvaluator @Since("2.3.0")
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164061850
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/evaluation/ClusteringEvaluatorSuite.scala
---
@@ -66,16 +66,38 @@ class ClusteringEvaluatorSuite
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164059420
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +460,220 @@ private[evaluation] object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164059036
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +460,220 @@ private[evaluation] object
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r164058701
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -111,6 +129,53 @@ object ClusteringEvaluator
}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r163940257
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -111,6 +129,53 @@ object ClusteringEvaluator
}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r163940508
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -111,6 +129,53 @@ object ClusteringEvaluator
}
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r163940933
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +460,220 @@ private[evaluation] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r163941171
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala
---
@@ -421,13 +460,220 @@ private[evaluation] object
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20396#discussion_r163941510
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/evaluation/ClusteringEvaluatorSuite.scala
---
@@ -66,16 +66,38 @@ class ClusteringEvaluatorSuite
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/20396
[SPARK-23217][ML] Add cosine distance measure to ClusteringEvaluator
## What changes were proposed in this pull request?
The PR provided an implementation of ClusteringEvaluator using the
24 matches
Mail list logo
