Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r184736836
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -116,21 +118,44 @@ object
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20490
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
GitHub user rdblue reopened a pull request:
https://github.com/apache/spark/pull/20490
[SPARK-23323][SQL]: Support commit coordinator for DataSourceV2 writes
## What changes were proposed in this pull request?
DataSourceV2 batch writes should use the output commit
Github user rdblue closed the pull request at:
https://github.com/apache/spark/pull/20490
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167645370
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -78,10 +88,11 @@ default void
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167644516
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -78,10 +88,11 @@ default void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167386197
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -116,21 +118,45 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167386169
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -116,21 +118,45 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167386125
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -78,10 +88,11 @@ default void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167386061
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -78,10 +88,11 @@ default void
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167321301
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -62,6 +62,16 @@
*/
DataWriterFactory
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167306077
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -62,6 +62,16 @@
*/
DataWriterFactory
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167280511
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -62,6 +62,16 @@
*/
DataWriterFactory
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167137165
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -62,6 +62,16 @@
*/
DataWriterFactory
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167011220
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -78,10 +78,11 @@ default void
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167011250
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -78,10 +78,11 @@ default void
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167011291
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
---
@@ -32,6 +32,16 @@
@InterfaceStability.Evolving
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r167009143
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166995080
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -78,10 +78,11 @@ default void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166899259
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166898992
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
---
@@ -32,6 +32,16 @@
@InterfaceStability.Evolving
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166898718
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -78,10 +78,11 @@ default void
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166898212
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
---
@@ -78,10 +78,11 @@ default void
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166684043
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
---
@@ -20,6 +20,7 @@
import java.io.Serializable;
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166514084
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
---
@@ -20,6 +20,7 @@
import java.io.Serializable;
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166463921
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166448459
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166447570
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166418424
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166398432
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166395788
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166381800
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166374405
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166360278
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20490#discussion_r166174605
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
---
@@ -117,20 +118,43 @@ object
35 matches
Mail list logo