[GitHub] spark pull request #20562: [SPARK-23275][SQL] fix the thread leaking in hive...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20562


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20562: [SPARK-23275][SQL] fix the thread leaking in hive...

[liufengdb]

GitHub user liufengdb opened a pull request:

https://github.com/apache/spark/pull/20562

[SPARK-23275][SQL] fix the thread leaking in hive/tests

## What changes were proposed in this pull request?

The two lines actually can trigger the hive metastore bug: 
https://issues.apache.org/jira/browse/HIVE-16844

The two configs are not in the default `ObjectStore` properties, so any run 
hive commands after these two lines will set the `propsChanged` flag in the 
`ObjectStore.setConf` and then cause thread leaks.

I don't think two lines are very useful and can be removed completed.

## How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, 
remove this)

Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liufengdb/spark fix-omm

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20562.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20562


commit 4e10f34ebb17940a1f0fd54ce26cb16d06320770
Author: Feng Liu 
Date:   2018-02-09T21:15:36Z

init: remove the two lines




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org