[GitHub] spark pull request #20610: [SPARK-23426][SQL] Use `hive` ORC implementation ...
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20610#discussion_r168267941 --- Diff: docs/sql-programming-guide.md --- @@ -1784,7 +1784,7 @@ working with timestamps in `pandas_udf`s to get the best performance, see Property NameDefaultMeaning spark.sql.orc.impl -native +hive --- End diff -- We do not need this in the migration guide. Please create a new section for ORC --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20610: [SPARK-23426][SQL] Use `hive` ORC implementation ...
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20610#discussion_r168268059 --- Diff: docs/sql-programming-guide.md --- @@ -1784,7 +1784,7 @@ working with timestamps in `pandas_udf`s to get the best performance, see Property NameDefaultMeaning spark.sql.orc.impl -native +hive --- End diff -- Yep. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20610: [SPARK-23426][SQL] Use `hive` ORC implementation ...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20610#discussion_r168267868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -399,11 +399,11 @@ object SQLConf {
val ORC_IMPLEMENTATION = buildConf("spark.sql.orc.impl")
.doc("When native, use the native version of ORC support instead of
the ORC library in Hive " +
- "1.2.1. It is 'hive' by default prior to Spark 2.3.")
+ "1.2.1. It is 'hive' by default.")
.internal()
.stringConf
.checkValues(Set("hive", "native"))
-.createWithDefault("native")
+.createWithDefault("hive")
--- End diff --
Oh, right.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #20610: [SPARK-23426][SQL] Use `hive` ORC implementation ...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20610#discussion_r168267722
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -399,11 +399,11 @@ object SQLConf {
val ORC_IMPLEMENTATION = buildConf("spark.sql.orc.impl")
.doc("When native, use the native version of ORC support instead of
the ORC library in Hive " +
- "1.2.1. It is 'hive' by default prior to Spark 2.3.")
+ "1.2.1. It is 'hive' by default.")
.internal()
.stringConf
.checkValues(Set("hive", "native"))
-.createWithDefault("native")
+.createWithDefault("hive")
--- End diff --
We also need to disable the ORC pushdown, because the ORC reader of Hive
1.2.1 has a few bugs.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
