Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20636
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r206748015
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSparkSubmitSuite.scala
---
@@ -39,8 +39,8 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r206638221
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSparkSubmitSuite.scala
---
@@ -39,8 +39,8 @@ class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r206638094
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSparkSubmitSuite.scala
---
@@ -55,22 +55,30 @@ object
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r195111027
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -61,12 +61,15 @@
* Grows the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r195110654
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -61,12 +61,15 @@
* Grows the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r195108390
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -61,12 +61,15 @@
* Grows the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r195107427
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -61,12 +61,15 @@
* Grows the
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r194526656
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -61,6 +61,10 @@
* Grows the
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r182025819
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSparkSubmitSuite.scala
---
@@ -39,8 +39,8 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r180528504
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSparkSubmitSuite.scala
---
@@ -39,8 +39,8 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r180507408
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSparkSubmitSuite.scala
---
@@ -39,8 +39,8 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r170482768
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSparkSubmitSuite.scala
---
@@ -58,15 +58,20 @@ object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20636#discussion_r169151430
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolderSparkSubmitSuite.scala
---
@@ -58,15 +58,20 @@
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/20636
[SPARK-23415][SQL][TEST] Make behavior of BufferHolderSparkSubmitSuite
correct and stable
## What changes were proposed in this pull request?
This PR addresses two issues in
15 matches
Mail list logo