[GitHub] spark pull request #20813: [SPARK-23670][SQL] Fix memory leak on SparkPlanGr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20813


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20813: [SPARK-23670][SQL] Fix memory leak on SparkPlanGr...

[vanzin]

Github user vanzin commented on a diff in the pull request:

https://github.com/apache/spark/pull/20813#discussion_r174202008
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusStore.scala
 ---
@@ -53,6 +53,9 @@ class SQLAppStatusStore(
   def executionsCount(): Long = {
 store.count(classOf[SQLExecutionUIData])
   }
+  def planGraphCount(): Long = {
--- End diff --

nit: add empty line before


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20813: [SPARK-23670][SQL] Fix memory leak on SparkPlanGr...

[myroslavlisniak]

GitHub user myroslavlisniak opened a pull request:

https://github.com/apache/spark/pull/20813

[SPARK-23670][SQL] Fix memory leak on SparkPlanGraphWrapper

## What changes were proposed in this pull request?
Clean up SparkPlanGraphWrapper objects from InMemoryStore together with 
cleaning up SQLExecutionUIData
## How was this patch tested?
existing unit test was extended to check also SparkPlanGraphWrapper object 
count


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myroslavlisniak/spark master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20813.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20813


commit f866701b322c9ddf2fddc49d162fc9bc8d83bcdb
Author: myroslavlisniak 
Date:   2018-03-13T11:22:07Z

fix memory leak on SparkPlanGraphWrapper




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org