[GitHub] spark pull request #20978: [SPARK-23861][SQL][Doc] Clarify default window fr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/20978


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20978: [SPARK-23861][SQL][Doc] Clarify default window fr...

[icexelloss]

Github user icexelloss commented on a diff in the pull request:

https://github.com/apache/spark/pull/20978#discussion_r179772706
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala ---
@@ -33,6 +33,10 @@ import org.apache.spark.sql.catalyst.expressions._
  *   Window.partitionBy("country").orderBy("date").rowsBetween(-3, 3)
  * }}}
  *
+ * @note When ordering is not defined, the default frame boundaries are 
(rowFrame,
--- End diff --

I think your wording is better. Updated.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20978: [SPARK-23861][SQL][Doc] Clarify default window fr...

[hvanhovell]

Github user hvanhovell commented on a diff in the pull request:

https://github.com/apache/spark/pull/20978#discussion_r179467893
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala ---
@@ -33,6 +33,10 @@ import org.apache.spark.sql.catalyst.expressions._
  *   Window.partitionBy("country").orderBy("date").rowsBetween(-3, 3)
  * }}}
  *
+ * @note When ordering is not defined, the default frame boundaries are 
(rowFrame,
--- End diff --

I tried to improve the wording (feel free not to use this):
```
When ordering is not defined, an unbounded window frame (rowFrame, 
unboundedPreceding, unboundedFollowing) is used by default. When ordering is 
defined, a growing window frame (rangeFrame, unboundedPreceding, currentRow) is 
used by default.
```


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20978: [SPARK-23861][SQL][Doc] Clarify default window fr...

[icexelloss]

Github user icexelloss closed the pull request at:

https://github.com/apache/spark/pull/20978


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20978: [SPARK-23861][SQL][Doc] Clarify default window fr...

[icexelloss]

GitHub user icexelloss reopened a pull request:

https://github.com/apache/spark/pull/20978

[SPARK-23861][SQL][Doc] Clarify default window frame boundaries with and 
without orderBy clause

## What changes were proposed in this pull request?

Add docstring to clarify default window frame boundaries with and without 
orderBy clause 

## How was this patch tested?

Manually generate doc and check.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/icexelloss/spark SPARK-23861-window-doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20978.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20978


commit 0b6f5fccf5e1cdda714c94e5daa34c6980bed4a7
Author: Li Jin 
Date:   2018-04-04T15:46:06Z

Add note for default frame boundaries

commit f96eaeaaa420cebfe8d3b7232edc62f4f3c12a74
Author: Li Jin 
Date:   2018-04-04T15:53:37Z

Reword




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20978: [SPARK-23861][SQL][Doc] Clarify default window fr...

[icexelloss]

GitHub user icexelloss opened a pull request:

https://github.com/apache/spark/pull/20978

[SPARK-23861][SQL][Doc] Clarify default window frame boundaries with and 
without orderBy clause

## What changes were proposed in this pull request?

Add docstring to clarify default window frame boundaries with and without 
orderBy clause 

## How was this patch tested?

Manually generate doc and check.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/icexelloss/spark SPARK-23861-window-doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20978.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20978


commit 0b6f5fccf5e1cdda714c94e5daa34c6980bed4a7
Author: Li Jin 
Date:   2018-04-04T15:46:06Z

Add note for default frame boundaries




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org