[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21040 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-05-04 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r186139938 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -378,6 +378,138 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-05-04 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r186133103 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -378,6 +378,138 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-05-04 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r186104739 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -378,6 +378,138 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-05-04 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r186103689 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -378,6 +378,138 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-05-04 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r186097518 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -378,6 +378,138 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-30 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r184914154 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -378,6 +378,138 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r184666357 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r184257279 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -105,4 +105,28 @@ class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-25 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r184257274 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-20 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r183100357 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -105,4 +105,28 @@ class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r182703273 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r182706982 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -102,6 +102,12 @@ trait

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r182701319 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r182701643 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r182701040 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r182702693 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-19 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r182705280 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala --- @@ -105,4 +105,28 @@ class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-13 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r181338128 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-13 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r181313290 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-12 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r181065461 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-12 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r181045317 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r180997886 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-12 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r180997042 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r180834827 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r180834135 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-11 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r180773760 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r180770274 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21040#discussion_r180766152 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +287,101 @@ case class

[GitHub] spark pull request #21040: [SPARK-23930][SQL] Add slice function

2018-04-11 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/21040 [SPARK-23930][SQL] Add slice function ## What changes were proposed in this pull request? The PR add the `slice` function. The behavior of the function is based on Presto's one.