[PR] [SPARK-47172][DOCS][FOLLOWUP] Fix spark.network.crypto.ciphersince version field on security page [spark]
yaooqinn opened a new pull request, #47353: URL: https://github.com/apache/spark/pull/47353 ### What changes were proposed in this pull request? Given that SPARK-47172 was an improvement but got merged into 3.4/3.5, we need to fix the since version to eliminate misunderstandings. ### Why are the changes needed? doc fix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? doc build ### Was this patch authored or co-authored using generative AI tooling? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47172][DOCS][FOLLOWUP] Fix spark.network.crypto.ciphersince version field on security page [spark]
yaooqinn commented on code in PR #47353: URL: https://github.com/apache/spark/pull/47353#discussion_r1677625009 ## docs/security.md: ## @@ -214,7 +214,7 @@ The following table describes the different options available for configuring th Cipher mode to use. Defaults "AES/CTR/NoPadding" for backward compatibility, which is not authenticated. Recommended to use "AES/GCM/NoPadding", which is an authenticated encryption mode. - 4.0.0 + 4.0.0, 3.5.2, 3.4.4 Review Comment: We will set this field to '3.4.4' as usual. It's okay when we fix it in one or two branches, but issues arise when we continue to backport more than 2 branches. The problem here is that it only tells us that 3.4.x (x>=4) and x.y.z (x>=4), but it can't tell us which version of 3.5 has it. I suggest that we add the full list of fixed versions according to the corresponding JIRA ticket. See the discussion here https://github.com/apache/spark/pull/47325#discussion_r1676826574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47172][DOCS][FOLLOWUP] Fix spark.network.crypto.ciphersince version field on security page [spark]
dongjoon-hyun commented on code in PR #47353: URL: https://github.com/apache/spark/pull/47353#discussion_r1678133239 ## docs/security.md: ## @@ -214,7 +214,7 @@ The following table describes the different options available for configuring th Cipher mode to use. Defaults "AES/CTR/NoPadding" for backward compatibility, which is not authenticated. Recommended to use "AES/GCM/NoPadding", which is an authenticated encryption mode. - 4.0.0 + 4.0.0, 3.5.2, 3.4.4 Review Comment: > We will set this field to '3.4.4' as usual. It's okay when we fix it in one or two branches, but issues arise when we continue to backport more than 2 branches. The problem here is that it only tells us that 3.4.x (x>=4) and x.y.z (x>=4), but it can't tell us which version of 3.5 has it. > > I suggest that we add the full list of fixed versions according to the corresponding JIRA ticket. > > See the discussion here [#47325 (comment)](https://github.com/apache/spark/pull/47325#discussion_r1676826574) To @yaooqinn , actually, I disagreed with the suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47172][DOCS][FOLLOWUP] Fix spark.network.crypto.ciphersince version field on security page [spark]
dongjoon-hyun commented on PR #47353: URL: https://github.com/apache/spark/pull/47353#issuecomment-2228964582 If we are going to allow the contributors to upgrade all configurations in this style, I'm +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47172][DOCS][FOLLOWUP] Fix spark.network.crypto.ciphersince version field on security page [spark]
yaooqinn commented on PR #47353: URL: https://github.com/apache/spark/pull/47353#issuecomment-2229869468 Hi @dongjoon-hyun If you don't mind I will start updating versions of existing configurations and add a guideline in website for incremental updates after 3.5.2-rc1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47172][DOCS][FOLLOWUP] Fix spark.network.crypto.ciphersince version field on security page [spark]
yaooqinn closed pull request #47353: [SPARK-47172][DOCS][FOLLOWUP] Fix spark.network.crypto.ciphersince version field on security page URL: https://github.com/apache/spark/pull/47353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47172][DOCS][FOLLOWUP] Fix spark.network.crypto.ciphersince version field on security page [spark]
dongjoon-hyun commented on PR #47353: URL: https://github.com/apache/spark/pull/47353#issuecomment-2229871468 Sure. Go ahead. I gave +1 to support this PR and the previous one. Initially, I was worried about consistency, but we can catch up them later, @yaooqinn . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47172][DOCS][FOLLOWUP] Fix spark.network.crypto.ciphersince version field on security page [spark]
yaooqinn commented on PR #47353: URL: https://github.com/apache/spark/pull/47353#issuecomment-2229871801 Thanks @dongjoon-hyun @mridulm, merged to master/3.5/3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
