Re: [PR] [SPARK-49550][FOLLOWUP][SQL][DOC] Switch Hadoop to 3.4.1 in IsolatedClientLoader and docs [spark]

2024-11-20 Thread via GitHub


pan3793 commented on code in PR #48890:
URL: https://github.com/apache/spark/pull/48890#discussion_r1847926317


##
docs/building-spark.md:
##
@@ -72,14 +72,11 @@ This will build Spark distribution along with Python pip 
and R packages. For mor
 
 ## Specifying the Hadoop Version and Enabling YARN
 
-You can specify the exact version of Hadoop to compile against through the 
`hadoop.version` property.
-
-You can enable the `yarn` profile and optionally set the `yarn.version` 
property if it is different
-from `hadoop.version`.

Review Comment:
   as Spark is using Hadoop shaded client, it makes no sense to have a 
separated `yarn.version`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-49550][FOLLOWUP][SQL][DOC] Switch Hadoop to 3.4.1 in IsolatedClientLoader and docs [spark]

2024-11-19 Thread via GitHub


LuciferYang closed pull request #48890: [SPARK-49550][FOLLOWUP][SQL][DOC] 
Switch Hadoop to 3.4.1 in IsolatedClientLoader and docs
URL: https://github.com/apache/spark/pull/48890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-49550][FOLLOWUP][SQL][DOC] Switch Hadoop to 3.4.1 in IsolatedClientLoader and docs [spark]

2024-11-19 Thread via GitHub


LuciferYang commented on PR #48890:
URL: https://github.com/apache/spark/pull/48890#issuecomment-2487223210

   Merged into master. Thanks @pan3793 and @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-49550][FOLLOWUP][SQL][DOC] Switch Hadoop to 3.4.1 in IsolatedClientLoader and docs [spark]

2024-11-19 Thread via GitHub


pan3793 commented on PR #48890:
URL: https://github.com/apache/spark/pull/48890#issuecomment-2485258115

   cc @dongjoon-hyun @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org