Re: [PR] [SPARK-51250][K8S] Add Support for K8s PriorityClass Configuration fo… [spark]
zemin-piao commented on PR #49998: URL: https://github.com/apache/spark/pull/49998#issuecomment-2899306689 @yaooqinn @dongjoon-hyun thanks for your questions. Lemme know if more clarification and discussion needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-51250][K8S] Add Support for K8s PriorityClass Configuration fo… [spark]
zemin-piao commented on PR #49998: URL: https://github.com/apache/spark/pull/49998#issuecomment-2813690026 > Kubernetes has a large number of APIs, and I'm quite sure which ones should be added to the Spark defaults. I think using `spark.kubernetes.driver.pod.featureSteps` is beneficial. > > Also cc @dongjoon-hyun Indeed in the released this is how I did priority class setting by using the customised feature step. I made this PR with this new spark config, with the thought that setting priority class is a generic thing for spark on k8s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-51250][K8S] Add Support for K8s PriorityClass Configuration fo… [spark]
zemin-piao commented on PR #49998: URL: https://github.com/apache/spark/pull/49998#issuecomment-2813695641 > I'm not sure about this part of the PR claim. When does this happen, @zemin-piao ? > > > In a cluster with numerous priority classes IMO it happens when multiple business criticalities needs to be defined within a cluster. This can also happen if in a cluster, a value based prioritisation needs to happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-51250][K8S] Add Support for K8s PriorityClass Configuration fo… [spark]
yaooqinn commented on PR #49998: URL: https://github.com/apache/spark/pull/49998#issuecomment-2811510414 Kubernetes has a large number of APIs, and I'm quite sure which ones should be added to the Spark defaults. I think using `spark.kubernetes.driver.pod.featureSteps` is beneficial. Also cc @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-51250][K8S] Add Support for K8s PriorityClass Configuration fo… [spark]
dongjoon-hyun commented on PR #49998: URL: https://github.com/apache/spark/pull/49998#issuecomment-2811516973 I'm not sure about this part of the PR claim. When does this happen? > In a cluster with numerous priority classes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-51250][K8S] Add Support for K8s PriorityClass Configuration fo… [spark]
zemin-piao commented on PR #49998: URL: https://github.com/apache/spark/pull/49998#issuecomment-2810753755 @yaooqinn if you have time could you maybe have a look? Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-51250][K8S] Add Support for K8s PriorityClass Configuration fo… [spark]
zemin-piao commented on PR #49998: URL: https://github.com/apache/spark/pull/49998#issuecomment-2715839216 Bump :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
