Re: [PR] [Test Only][BUILD] Test sbt 1.10.5 [spark]
panbingkun commented on PR #48972: URL: https://github.com/apache/spark/pull/48972#issuecomment-2505135654 The cost time of test `dev/mima` - Before - After https://github.com/panbingkun/spark/actions/runs/12060175806/job/33630180762 https://github.com/user-attachments/assets/a56269bc-6777-449b-accd-a2e037abbdde";> https://github.com/panbingkun/spark/actions/runs/12049152851/job/33598573658 https://github.com/user-attachments/assets/58e82ba9-f6b8-47ee-8f5a-16a4fa3b19e2";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [Test Only][BUILD] Test sbt 1.10.5 [spark]
panbingkun commented on PR #48972: URL: https://github.com/apache/spark/pull/48972#issuecomment-2505102693 By using environment variables `SKIP_LOCAL_M2`, the logic of `skip maven local resolver` is limited to `dev/mima` only, and the logic executed `on GA` and `on local` is already consistent. Based on this discussion https://github.com/coursier/coursier/issues/2942#issuecomment-2145674637, `coursier` (sbt relies on it) will not solve this problem in the short term. @LuciferYang @dongjoon-hyun Can we upgrade `sbt` through this workaround? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [Test Only][BUILD] Test sbt 1.10.5 [spark]
panbingkun commented on code in PR #48972: URL: https://github.com/apache/spark/pull/48972#discussion_r1860482825 ## dev/mima: ## @@ -24,6 +24,9 @@ set -e FWDIR="$(cd "`dirname "$0"`"/..; pwd)" cd "$FWDIR" +# Skip maven local resolver. +export SKIP_LOCAL_M2=true Review Comment: We make `dev/mima` ignore the `maven local cache` directly, so that the environment and process that all tests depend on are consistent in both `GA` and `local`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [Test Only][BUILD] Test sbt 1.10.5 [spark]
panbingkun commented on code in PR #48972: URL: https://github.com/apache/spark/pull/48972#discussion_r1860482825 ## dev/mima: ## @@ -24,6 +24,9 @@ set -e FWDIR="$(cd "`dirname "$0"`"/..; pwd)" cd "$FWDIR" +# Skip maven local resolver. +export SKIP_LOCAL_M2=true Review Comment: We make `dev/mima` ignore the `local maven cache` directly, so that the environment and process that all tests depend on are consistent in both `GA` and `local`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
