[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

wilfred-s commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444922722 ## File path: pkg/events/event_cache.go ## @@ -0,0 +1,117 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444911414 ## File path: pkg/events/event_cache.go ## @@ -0,0 +1,117 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444930056 ## File path: pkg/events/event_store_test.go ## @@ -0,0 +1,130 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or

[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #172: [YUNIKORN-107] Display additional queue information

TravisBuddy commented on pull request #172: URL: https://github.com/apache/incubator-yunikorn-core/pull/172#issuecomment-648799046 Hey @kingamarton, Your changes look good to me! View build log ## TravisBuddy Request Identifier: 16e4ea40-b619-11ea-aaf6-456b40a357ff

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444919736 ## File path: pkg/events/event_cache.go ## @@ -0,0 +1,117 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444926168 ## File path: pkg/events/event_publisher.go ## @@ -0,0 +1,94 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or

[GitHub] [incubator-yunikorn-core] kingamarton commented on a change in pull request #172: [YUNIKORN-107] Display additional queue information

kingamarton commented on a change in pull request #172: URL: https://github.com/apache/incubator-yunikorn-core/pull/172#discussion_r444867447 ## File path: pkg/cache/queue_info_test.go ## @@ -425,6 +425,8 @@ func TestGetQueueInfos(t *testing.T) { assert.NilError(t,

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444907408 ## File path: pkg/entrypoint/entrypoint.go ## @@ -54,10 +57,18 @@ func StartAllServicesWithManualScheduler() *ServiceContext {

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444929532 ## File path: pkg/events/event_store.go ## @@ -0,0 +1,86 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #173: [YUNIKORN-231] Add ability to update pod condition based on accurate scheduling state

TravisBuddy commented on pull request #173: URL: https://github.com/apache/incubator-yunikorn-core/pull/173#issuecomment-648614503 ## Travis tests have failed Hey @yangwwei, Please read the following log in order to understand the failure reason. It'll be awesome if you fix

[GitHub] [incubator-yunikorn-core] wilfred-s closed pull request #143: [YUNIKORN-135] Move the scheduler-interface related constants from the markdown to the common package

wilfred-s closed pull request #143: URL: https://github.com/apache/incubator-yunikorn-core/pull/143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #173: [YUNIKORN-231] Add ability to update pod condition based on accurate scheduling state

TravisBuddy commented on pull request #173: URL: https://github.com/apache/incubator-yunikorn-core/pull/173#issuecomment-648680689 Hey @yangwwei, Your changes look good to me! View build log ## TravisBuddy Request Identifier: ae4e1830-b5f5-11ea-aaf6-456b40a357ff

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444932863 ## File path: pkg/events/event_store_test.go ## @@ -0,0 +1,130 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444959534 ## File path: pkg/scheduler/scheduling_application.go ## @@ -418,6 +420,15 @@ func (sa *SchedulingApplication) tryAllocate(headRoom

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444959860 ## File path: pkg/scheduler/scheduling_application.go ## @@ -703,3 +714,10 @@ func (sa *SchedulingApplication) finishRecovery() {

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444957752 ## File path: pkg/plugins/types.go ## @@ -18,12 +18,19 @@ package plugins -import

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444957191 ## File path: pkg/plugins/plugins.go ## @@ -50,19 +53,41 @@ func RegisterSchedulerPlugin(plugin interface{}) {

[GitHub] [incubator-yunikorn-core] yangwwei merged pull request #172: [YUNIKORN-107] Display additional queue information

yangwwei merged pull request #172: URL: https://github.com/apache/incubator-yunikorn-core/pull/172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

wilfred-s commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444960603 ## File path: pkg/events/events.go ## @@ -0,0 +1,40 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444937910 ## File path: pkg/events/events.go ## @@ -0,0 +1,40 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] [incubator-yunikorn-core] wilfred-s commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

wilfred-s commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444959075 ## File path: pkg/events/event_publisher.go ## @@ -0,0 +1,89 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444993470 ## File path: pkg/entrypoint/entrypoint.go ## @@ -73,6 +84,12 @@ func startAllServicesWithParameters(opts StartupOptions)

[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #141: [YUNIKORN-117] Create event cache for queue and application events

TravisBuddy commented on pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#issuecomment-648949351 ## Travis tests have failed Hey @adamantal, Please read the following log in order to understand the failure reason. It'll be awesome if you fix

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444992030 ## File path: pkg/events/event_cache_test.go ## @@ -0,0 +1,170 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or

[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #141: [YUNIKORN-117] Create event cache for queue and application events

yangwwei commented on pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#issuecomment-648959708 Looks like it is failing on lint check. I can help to fix this for this PR. This is an

[GitHub] [incubator-yunikorn-core] adamantal commented on a change in pull request #141: [YUNIKORN-117] Create event cache for queue and application events

adamantal commented on a change in pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#discussion_r444991772 ## File path: pkg/events/event_cache_test.go ## @@ -0,0 +1,170 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or

[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #141: [YUNIKORN-117] Create event cache for queue and application events

wilfred-s commented on pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#issuecomment-648938439 Waiting for travis to see if the data races have ben fixed. Change overall looks good enough for commit as a first phase.

[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #141: [YUNIKORN-117] Create event cache for queue and application events

TravisBuddy commented on pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#issuecomment-649012984 Hey @adamantal, Your changes look good to me! View build log ## TravisBuddy Request Identifier: 9acc0e30-b64e-11ea-aaf6-456b40a357ff

[GitHub] [incubator-yunikorn-k8shim] yangwwei opened a new pull request #140: [YUNIKORN-251] Post recovery release a pod may disrupt running pods

yangwwei opened a new pull request #140: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/140 I found this issue while testing recovery. It can be reproduced with the following steps: 1. Create an application, it launches multiple pods, keeps them running 2. Restart

[GitHub] [incubator-yunikorn-core] codecov-commenter commented on pull request #141: [YUNIKORN-117] Create event cache for queue and application events

codecov-commenter commented on pull request #141: URL: https://github.com/apache/incubator-yunikorn-core/pull/141#issuecomment-649013030 # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/141?src=pr=h1) Report > Merging

[GitHub] [incubator-yunikorn-k8shim] wangdatan commented on pull request #140: [YUNIKORN-251] Post recovery release a pod may disrupt running pods

wangdatan commented on pull request #140: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/140#issuecomment-649100869 @yangwwei , this looks bad. Is it possible to add a unit test to ensure this won't break in the future?

[GitHub] [incubator-yunikorn-k8shim] ayubpathan opened a new pull request #141: YUNIKORN-252: Fix the test to accommodate changes introduced as part of YUNIKORN-222

ayubpathan opened a new pull request #141: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #140: [YUNIKORN-251] Post recovery release a pod may disrupt running pods

yangwwei commented on pull request #140: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/140#issuecomment-649149303 > @yangwwei , this looks bad. Is it possible to add a unit test to ensure this won't break in the future? Yes. I've added the UT to cover this.

[GitHub] [incubator-yunikorn-k8shim] yangwwei merged pull request #141: [YUNIKORN-252]: Fix the test to accommodate changes introduced as part of YUNIKORN-222

yangwwei merged pull request #141: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #177: [YUNIKORN-241] priority sorting quick fix

wilfred-s commented on pull request #177: URL: https://github.com/apache/incubator-yunikorn-core/pull/177#issuecomment-649236420 The unit test failure is due to the known data race logged as YUNIKORN-202 This is an

[GitHub] [incubator-yunikorn-core] wilfred-s edited a comment on pull request #177: [YUNIKORN-241] priority sorting quick fix

wilfred-s edited a comment on pull request #177: URL: https://github.com/apache/incubator-yunikorn-core/pull/177#issuecomment-649236420 The unit test failure is due to the known data race logged as YUNIKORN-202 That is not related to the change of the sorter that was made

[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #175: [YUNIKORN-241] add request sorting policy

yangwwei commented on a change in pull request #175: URL: https://github.com/apache/incubator-yunikorn-core/pull/175#discussion_r444593859 ## File path: pkg/scheduler/policies/sorting_policy.go ## @@ -26,14 +26,15 @@ import ( type SortPolicy int const ( -

[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #128: [YUNIKORN-117] Create event cache for queue and application events

wilfred-s commented on a change in pull request #128: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/128#discussion_r444965276 ## File path: pkg/cache/task.go ## @@ -415,3 +416,19 @@ func (task *Task) enterState(event *fsm.Event) {

[GitHub] [incubator-yunikorn-core] wilfred-s opened a new pull request #177: [YUNIKORN-241] priority sorting quick fix

wilfred-s opened a new pull request #177: URL: https://github.com/apache/incubator-yunikorn-core/pull/177 Quick fix to change priority sorting to FIFO sorting for requests based on the fact that the shim does not set priority.

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #128: [YUNIKORN-117] Create event cache for queue and application events

yangwwei commented on a change in pull request #128: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/128#discussion_r445311398 ## File path: pkg/callback/scheduler_callback.go ## @@ -143,3 +144,35 @@ func (callback *AsyncRMCallback) ReSyncSchedulerCache(args