yangwwei merged pull request #290:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
updown321 commented on pull request #43:
URL:
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43#issuecomment-890350170
> @updown321 it is not triggering the github action run, any idea why?
I have not found it yet. still trying
--
This is an automated messag
wilfred-s commented on pull request #42:
URL:
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/42#issuecomment-890687930
No it is a full replacement of #40. #40 does not fix most of the problems.
It allows us to build if you have most of the tools already in your
envi
wilfred-s commented on pull request #42:
URL:
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/42#issuecomment-890688318
I seem to have a problem adding @manirajv06 as a reviewer. He should be on
the committer list but is not on the committer list in github.
--
This
wilfred-s commented on a change in pull request #43:
URL:
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43#discussion_r680637529
##
File path: .github/workflows/main.yml
##
@@ -0,0 +1,22 @@
+name: Pre-commit checks
+
+on:
+ pull_request:
Review commen
yangwwei merged pull request #42:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
wilfred-s closed pull request #40:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
wilfred-s commented on pull request #40:
URL:
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/40#issuecomment-890694230
This was superseded by #42 to fix more issues found.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
wilfred-s opened a new pull request #287:
URL: https://github.com/apache/incubator-yunikorn-core/pull/287
### What is this PR for?
The license check run as part of the PR workflow always passes when run on
linux.
The recursive grep redirect to a variable does not work.
### What
codecov[bot] commented on pull request #287:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/287#issuecomment-890726602
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/287?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
wilfred-s opened a new pull request #291:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/291
### What is this PR for?
The license check run as part of the PR workflow always passes when run on
linux.
The recursive grep redirect to a variable does not work.
### Wh
codecov[bot] commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/291#issuecomment-890734422
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campa
wilfred-s opened a new pull request #59:
URL: https://github.com/apache/incubator-yunikorn-web/pull/59
### What is this PR for?
The comments are confusing and point to unused code. This unused code might
not align with the Apache license.
We should not reference it.
### What ty
wilfred-s opened a new pull request #60:
URL: https://github.com/apache/incubator-yunikorn-web/pull/60
### What is this PR for?
The license check run as part of the PR workflow always passes when run on
linux.
The recursive grep redirect to a variable does not work.
### What ty
chia7712 opened a new pull request #288:
URL: https://github.com/apache/incubator-yunikorn-core/pull/288
### What is this PR for?
Both files are good examples to users so it would be nice to correct them.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
*
codecov[bot] commented on pull request #288:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/288#issuecomment-890892760
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/288?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
HuangTing-Yao opened a new pull request #292:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/292
### What is this PR for?
Call and check the yunikorn HealthCheck API in all kind of e2e test.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [
kingamarton merged pull request #59:
URL: https://github.com/apache/incubator-yunikorn-web/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codecov[bot] commented on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#issuecomment-890943113
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campa
wilfred-s commented on pull request #281:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/281#issuecomment-890948140
Looking at the code and the tests I think there is a problem with the
calculation.
This is the base you gave:
```
// pod
// initcontainer
wilfred-s edited a comment on pull request #281:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/281#issuecomment-890948140
Looking at the code and the tests I think there is a problem with the
calculation.
This is the base you gave:
```
// pod
// initco
codecov[bot] edited a comment on pull request #288:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/288#issuecomment-890892760
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/288?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
chia7712 commented on pull request #288:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/288#issuecomment-890983433
> can we make sure the file ends with a newline?
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
codecov[bot] edited a comment on pull request #288:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/288#issuecomment-890892760
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/288?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
chia7712 opened a new pull request #289:
URL: https://github.com/apache/incubator-yunikorn-core/pull/289
… ought to use to release lock
### What is this PR for?
make sure `release` happens after the surrounding function returns
### What type of PR is it?
* [ ] - Bug
codecov[bot] commented on pull request #289:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/289#issuecomment-891044599
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
0yukali0 commented on pull request #281:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/281#issuecomment-891050726
Thanks, i will fix it.
Wilfred Spiegelenburg ***@***.***> 於 2021年8月2日 週一 下午7:24寫道：
> Looking at the code and the tests I think there is a problem w
chia7712 commented on pull request #289:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/289#issuecomment-891060933
oh, that is a recursive function. will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
chia7712 closed pull request #289:
URL: https://github.com/apache/incubator-yunikorn-core/pull/289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codecov[bot] edited a comment on pull request #281:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/281#issuecomment-878248140
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&ut
updown321 commented on a change in pull request #43:
URL:
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43#discussion_r681047754
##
File path: .github/workflows/main.yml
##
@@ -0,0 +1,22 @@
+name: Pre-commit checks
+
+on:
+ pull_request:
Review commen
0yukali0 opened a new pull request #68:
URL: https://github.com/apache/incubator-yunikorn-site/pull/68
What is this PR for?
Add apache 2.0 license file to the site repo
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-712
--
This is an automated message
updown321 commented on pull request #43:
URL:
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43#issuecomment-891138527
I can run correct action when I push it, but still cannot trigger the action
when PR
--
This is an automated message from the Apache Git Service.
updown321 closed pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
updown321 opened a new pull request #44:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/44
### What is this PR for?
test action
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ]
updown321 closed pull request #44:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
yangwwei merged pull request #68:
URL: https://github.com/apache/incubator-yunikorn-site/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: r
yangwwei commented on a change in pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#discussion_r681280615
##
File path: test/e2e/app/app_test.go
##
@@ -113,6 +113,16 @@ var _ = ginkgo.Describe("App", func() {
gomega.Ω
ronazhan commented on a change in pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#discussion_r681378383
##
File path: test/e2e/framework/helpers/yunikorn/rest_api_utils.go
##
@@ -224,6 +224,17 @@ func isRootSched(policy string) wait.Conditi
ronazhan commented on a change in pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#discussion_r681381919
##
File path: test/e2e/app/app_test.go
##
@@ -113,6 +113,16 @@ var _ = ginkgo.Describe("App", func() {
gomega.Ω
ronazhan commented on a change in pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#discussion_r681382274
##
File path: test/e2e/app/app_test.go
##
@@ -113,6 +113,16 @@ var _ = ginkgo.Describe("App", func() {
gomega.Ω
kobe860219 opened a new pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61
### What is this PR for?
Showing "node sort policy" in UI dashboard.
### What type of PR is it?
* [ ] - Bug Fix
* [ x ] - Improvement
* [ ] - Feature
* [ ] - Doc
craigcondit opened a new pull request #290:
URL: https://github.com/apache/incubator-yunikorn-core/pull/290
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
http://yunikorn.apache.org/co
yangwwei closed pull request #61:
URL: https://github.com/apache/incubator-yunikorn-web/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: re
yangwwei commented on pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-892188139
thank you @kobe860219 for working on this, thank you @akhilpb001 for the
review.
the pre-commit check fails, could u pls take a look?
--
This is an automate
codecov[bot] commented on pull request #290:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/290#issuecomment-892288348
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/290?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
chia7712 opened a new pull request #291:
URL: https://github.com/apache/incubator-yunikorn-core/pull/291
### What is this PR for?
That helps us observe the "application.sort.policy" through REST APIs.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [
chia7712 commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-892578897
I will another PR to update the APIs doc
(https://yunikorn.apache.org/docs/api/scheduler) after this PR is accepted
--
This is an automated message from the Ap
codecov[bot] commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-892635868
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
codecov[bot] edited a comment on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#issuecomment-890943113
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&ut
codecov[bot] edited a comment on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#issuecomment-890943113
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&ut
codecov[bot] edited a comment on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#issuecomment-890943113
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&ut
codecov[bot] edited a comment on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#issuecomment-890943113
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&ut
codecov[bot] edited a comment on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#issuecomment-890943113
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&ut
yangwwei commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-892786643
@manirajv06 can u help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
yangwwei commented on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#issuecomment-892838653
Looks much better. @ronazhan can you pls give another look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message,
yangwwei merged pull request #288:
URL: https://github.com/apache/incubator-yunikorn-core/pull/288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yangwwei merged pull request #287:
URL: https://github.com/apache/incubator-yunikorn-core/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yangwwei merged pull request #60:
URL: https://github.com/apache/incubator-yunikorn-web/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: re
yangwwei merged pull request #291:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
codecov[bot] edited a comment on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-892635868
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
codecov[bot] edited a comment on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-892635868
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
yangwwei commented on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#issuecomment-892838653
Looks much better. @ronazhan can you pls give another look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message,
codecov[bot] edited a comment on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/292#issuecomment-890943113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
yangwwei merged pull request #60:
URL: https://github.com/apache/incubator-yunikorn-web/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: re
codecov[bot] edited a comment on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-892635868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
chia7712 commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-892578897
I will another PR to update the APIs doc
(https://yunikorn.apache.org/docs/api/scheduler) after this PR is accepted
--
This is an automated message from the Ap
yangwwei merged pull request #288:
URL: https://github.com/apache/incubator-yunikorn-core/pull/288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yangwwei merged pull request #291:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
codecov[bot] commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-892635868
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/291?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
yangwwei commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-892786643
@manirajv06 can u help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
yangwwei merged pull request #287:
URL: https://github.com/apache/incubator-yunikorn-core/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kobe860219 commented on pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-893388090
Hi @akhilpb001 ! There is aa error in pre-commit check. I found the problem
below when `make test` :
![image](https://user-images.githubusercontent.com/4802729
kobe860219 edited a comment on pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-893388090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 opened a new pull request #292:
URL: https://github.com/apache/incubator-yunikorn-core/pull/292
…the queue is under a non-leaf dynamical queue
### What is this PR for?
The non-leaf dynamical queue can't get properties so it can' pass any
properties to its leaf queue.
codecov[bot] commented on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/292#issuecomment-893461808
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/292?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
yangwwei commented on pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-893622080
seems like the travis job is still failing:
https://app.travis-ci.com/github/apache/incubator-yunikorn-web/jobs/529229491.
it says: The command "yarn test:coverag
yangwwei merged pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
ycr-oss commented on pull request #285:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/285#issuecomment-893775382
Hi @HuangTing-Yao, what's the status of this PR? Do you need help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
yangwwei merged pull request #291:
URL: https://github.com/apache/incubator-yunikorn-core/pull/291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wilfred-s commented on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/292#issuecomment-893920975
The design was never intended for a hierarchical copy of the application
sort policy. It was a simple fix for just the direct parent to a leaf queue.
Anything e
kobe860219 commented on pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-893962927
@yangwwei It's the same error when I run the same command locally. The
problem outputs the info `TypeError: this.scheduler.fetchPartitionList is not a
function`
chia7712 commented on pull request #292:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/292#issuecomment-893984102
@wilfred-s thanks for your feedback.
> There is a jira open to add a template that we can set for inheritance.
YUNIKORN-193. It has not been worked on but
HuangTing-Yao commented on pull request #285:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/285#issuecomment-893984668
Hi @ycr-oss , I am glad that you can help, After my change in this PR, those
are some UT failed.
I am trying figure it out, but with this PR, DaemonSet ca
ycr-oss commented on pull request #285:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/285#issuecomment-893989780
@HuangTing-Yao Looks like the test failures all come from this file:
https://github.com/apache/incubator-yunikorn-core/blob/master/pkg/scheduler/partition_test.go.
chia7712 opened a new pull request #69:
URL: https://github.com/apache/incubator-yunikorn-site/pull/69
issue: https://issues.apache.org/jira/browse/YUNIKORN-784
this is a follow-up of
https://github.com/apache/incubator-yunikorn-core/pull/291
--
This is an automated message from t
HuangTing-Yao commented on pull request #285:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/285#issuecomment-893994191
@ycr-oss Thanks, I will also keep fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
manirajv06 commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-894020336
> looks @manirajv06 is not available right now.
> this is a straightforward fix, looks good to me, thank you @chia7712 !
Sorry for the delay. @chia7712
chia7712 commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-894034090
> Can we modify TestGetPartitionQueuesHandler in handlers_test.go to cover
this change as it would be more appropriate?
sure
> Can we create a sepa
chia7712 opened a new pull request #293:
URL: https://github.com/apache/incubator-yunikorn-core/pull/293
### What is this PR for?
add test to handler_test.go (see
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-894020336)
### What type of PR is it?
*
chia7712 commented on pull request #291:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/291#issuecomment-894045918
> Can we modify TestGetPartitionQueuesHandler in handlers_test.go to cover
this change as it would be more appropriate?
https://github.com/apache/incubator
codecov[bot] commented on pull request #293:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/293#issuecomment-894047022
#
[Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/293?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=
akhilpb001 commented on pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-894049371
Hi @kobe860219, this is unit test failure. Add following lines to
`MockSchedulerService` in `mocks.ts` file to fix this.
```
fetchPartionList: () => of([]),
akhilpb001 commented on a change in pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#discussion_r683997845
##
File path: src/app/app.component.ts
##
@@ -55,11 +55,11 @@ export class AppComponent implements OnInit {
do {
const children
akhilpb001 commented on a change in pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#discussion_r683997845
##
File path: src/app/app.component.ts
##
@@ -55,11 +55,11 @@ export class AppComponent implements OnInit {
do {
const children
kobe860219 commented on pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-894252347
@yangwwei The pre-commit check passed now. Thanks @akhilpb001 help. I
disabled my IDE's prettier and use `yarn prettify` to format insteed.
--
This is an auto
updown321 opened a new pull request #45:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/45
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide -
http://yunikorn.ap
yangwwei commented on pull request #45:
URL:
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/45#issuecomment-894374814
thanks for testing this out, @updown321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
yangwwei closed pull request #45:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
yangwwei commented on pull request #61:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/61#issuecomment-894376762
thank you @kobe860219 for getting this done
and thank you @akhilpb001 for the review and suggestions!
--
This is an automated message from the Apache Git Servic
1 - 100 of 8443 matches
Mail list logo
