[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #180: [YUNIKORN-255] Cleanup code from event cache change

2020-06-29 Thread GitBox 


TravisBuddy commented on pull request #180:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/180#issuecomment-651059124


   Hey @adamantal,  
   Your changes look good to me!
   
   View
 build log
   
   ## TravisBuddy Request Identifier: 344038f0-b9fd-11ea-a74d-ef5d1a577ce8
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #180: [YUNIKORN-255] Cleanup code from event cache change

2020-06-29 Thread GitBox 


TravisBuddy commented on pull request #180:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/180#issuecomment-651042841


   ## Travis tests have failed
   
   Hey @adamantal,
   Please read the following log in order to understand the failure reason.
   It'll be awesome if you fix what's wrong and commit the changes.
   
   
   ### 1st Build
   
   View
 build log
   
   
   
 
   
curl -sSfL 
https:raw.githubusercontent.comgolangcigolangci-lintmasterinstall.sh
 | sh -s -- -b $(go env GOPATH)bin v1.22.2
   
 
   
   ```
   golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
   golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
   golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
   ```
   
   
   
   
   
 
   
make lint
   
 
   
   ```
   running golangci-lint
   pkg/events/event_cache_test.go:106: File is not `gofmt`-ed with `-s` (gofmt)
ObjectID: "alloc" + strconv.Itoa(i / 2),
GroupID:  "app" + strconv.Itoa(i / 2),
   pkg/events/event_store_test.go:63: File is not `gofmt`-ed with `-s` (gofmt)
ObjectID: "alloc" + strconv.Itoa(i / 2),
GroupID:  "app" + strconv.Itoa(i / 2),
   Makefile:45: recipe for target 'lint' failed
   make: *** [lint] Error 1
   ```
   
   
   
   
   ## TravisBuddy Request Identifier: a86c9de0-b9f8-11ea-a74d-ef5d1a577ce8
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org