Re: [rkward-devel] import/export CSV

2014-12-02 Thread Thomas Friedrichsmeier
Hi, On Monday 01 December 2014 22:11:39 meik michalke wrote: > here's a refined version, what do think of the restructured comments? definitely better, IMO. I'd suggest also putting all implicit paramteres on a single line of the comment, though, so the comment does not push the actual code out

Re: [rkward-devel] import/export CSV

2014-12-02 Thread meik michalke
hi, thanks for the fast feedback. Am Dienstag, 2. Dezember 2014, 09:59:12 schrieb Thomas Friedrichsmeier: > On Monday 01 December 2014 22:11:39 meik michalke wrote: > > here's a refined version, what do think of the restructured comments? > > definitely better, IMO. I'd suggest also putting all

Re: [rkward-devel] import/export CSV

2014-12-02 Thread Thomas Friedrichsmeier
Hi, On Tuesday 02 December 2014 11:46:52 meik michalke wrote: > shuffling around elements is no problem, i'll try something. however: > > - Set the labels of the inputs for custom dec/sep to "" (these are > > definitely expendable, IMO) > > - Set the label of the file name selector to "". Probably

Re: [rkward-devel] [rkward-cvs] [rkward] rkward/plugins: added the new table/CSV export dialog for better testing. also added a help page and included the generator script.

2014-12-02 Thread Thomas Friedrichsmeier
Hi! Just a small random catch: On Tuesday 02 December 2014 21:54:50 m. eik michalke wrote: > + var quote = getBoolean("quote"); This works, and is ok. However, the canonical way to deal with checkbox- options is using getBoolean("quote.state") and not specifying any value in the -contr