Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Updates: Status: Done Comment #10 on issue 192 by pekka.klarck: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Comment #9 on issue 192 by c.martin.taylor: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 What you've got is fine... don't do any more. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Comment #8 on issue 192 by pekka.klarck: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 Hmm, I just started to think that INFO level would be better since seeing the round that something special happened might be really important. Counting rounds manually when you have dozens of them is not that fun. In this case I wouldn't like to include the name of the keyword since it's a bit of duplication as the message is inside that keyword. In r1221 I changed the wording to "Repeating keyword, round %d/%d" and added another message when the keyword is not repeated at all. It's still easy to change the wording but we probably shouldn't spent too much time for this. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Comment #7 on issue 192 by c.martin.taylor: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 Sure, DEBUG level would be fine. As a DEBUG message I think more information is better, so I think the name of the keyword being repeated should be included. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Comment #6 on issue 192 by pekka.klarck: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 Thanks for comments Martin. 'Repeating keyword' is much better than 'Executing round' but do we need to repeat also the name of the keyword? Would DEBUG level (i.e. hiding the message by default) be better? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Comment #5 on issue 192 by c.martin.taylor: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 Yes, the new Repeat Keyword works just as I imagined it would. Thanks for the quick turnaround on this! The logging "Executing round 1/5" is a bit confusing, partially because its in the log lines for the executed keyword and partially because of the wording. The wording might be improved with: "Repeating keyword '%s' %d/%d" % (name, i+1, times) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Updates: Status: Started Comment #4 on issue 192 by pekka.klarck: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 Tests commited in r1219. I think logging the execution round is a good idea but not sure should we use INFO or DEBUG level. I'm a bit worried that INFO is confusing (these messages go under the executed keyword) and extra messages increase the log file size. Any comments from others? Martin, could you try this keyword and see does it a) work for you, and b) what you think about logging? You can simply copy the latest version of BuiltIn from http://robotframework.googlecode.com/svn/trunk/src/robot/libraries/BuiltIn.py Logging must also be mentioned in the keyword's documentation. After that this issue is done. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Updates: Owner: pekka.klarck Comment #3 on issue 192 by pekka.klarck: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 Initial implementation commited in r1217. Issues 1-3 above implemented. Missing/open things: 1) Should we write messages like "Executing round 2/42" to log? Current implementation does it, but these messages are inside executed keywords. This is due to how capturing the stdout works and isn't easy to change. Is that a problem? Should we use DEBUG instead? 2) Tests are totally missing. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Comment #2 on issue 192 by pekka.klarck: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 Few comments about the implementation: 1) In addition to giving the number of times to repeat the keyword as an integer, I propose we support also following formats (ignoring case and spaces). | Repeat Keyword | 2 times | Some Keyword | | Repeat Keyword | 2 x | Some Keyword | The former format is easiest to read and the latter is close to the old repeat syntax. 2) It should be possible to give the number of times a keyword is repeated as a variable. Since the count is an argument to "Repeat Keyword" this works automatically. 3) If the number of times to repeat a keyword is zero or negative, the actual keyword should not be executed at all and Repeat Keyword itself should pass. 4) Repeat Keyword should perhaps automatically log something like "Executing round 2/42". -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
Issue 192 in robotframework: "Repeat Keyword" BuiltIn keyword
Updates: Summary: "Repeat Keyword" BuiltIn keyword Status: Accepted Labels: -Priority-Medium Priority-High Target-2.0.4 Comment #1 on issue 192 by pekka.klarck: "Repeat Keyword" BuiltIn keyword http://code.google.com/p/robotframework/issues/detail?id=192 Robot Framework actually has a special syntax for repeating a keyword any number of times. See issue 193 why that syntax isn't that useful these days and why "Repeat Keyword" is a much better idea. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings
