Re: Issue 1632 in robotframework: --suite option doesn't work when dot in filename and running folder

2014-01-26 Thread robotframework

Updates:
Status: Done

Comment #6 on issue 1632 by pekka.klarck: --suite option doesn't work when  
dot in filename and running folder

http://code.google.com/p/robotframework/issues/detail?id=1632

This issue was updated by revision 60b4d6e45b74.

Looked very good. The algorithm to generate suite names was a bit hard to  
understand, so I changed it to use more explicit `while '.' not in suite`  
loop. Also added some more cases to the unit test to verify the  
implementation.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--

--- 
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 1632 in robotframework: --suite option doesn't work when dot in filename and running folder

2014-01-23 Thread robotframework

Updates:
Status: Review
Cc: pekka.klarck

Comment #5 on issue 1632 by mikko.ko...@gmail.com: --suite option doesn't  
work when dot in filename and running folder

http://code.google.com/p/robotframework/issues/detail?id=1632

Old comment removed in r416dd7dcb014

Ready for review.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--

--- 
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 1632 in robotframework: --suite option doesn't work when dot in filename and running folder

2014-01-23 Thread robotframework


Comment #4 on issue 1632 by mikko.ko...@gmail.com: --suite option doesn't  
work when dot in filename and running folder

http://code.google.com/p/robotframework/issues/detail?id=1632

Fix and unit test in r57b935c8325d and acceptance test in r20b19634410e

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--

--- 
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 1632 in robotframework: --suite option doesn't work when dot in filename and running folder

2014-01-22 Thread robotframework


Comment #3 on issue 1632 by mikko.ko...@gmail.com: --suite option doesn't  
work when dot in filename and running folder

http://code.google.com/p/robotframework/issues/detail?id=1632

The bug is in robot.parsing.populators  
FromDirectoryPopulator._get_include_suites in:

# Use only the last part of names given like '--suite parent.child'
incl_suites = SuiteNamePatterns(i.split('.')[-1] for i in incl_suites or [])

This doesn't work when filename contains '.'

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--

--- 
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 1632 in robotframework: --suite option doesn't work when dot in filename and running folder

2014-01-22 Thread robotframework

Updates:
Owner: mikko.ko...@gmail.com

Comment #2 on issue 1632 by mikko.ko...@gmail.com: --suite option doesn't  
work when dot in filename and running folder

http://code.google.com/p/robotframework/issues/detail?id=1632

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--

--- 
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 1632 in robotframework: --suite option doesn't work when dot in filename and running folder

2014-01-20 Thread robotframework

Updates:
Labels: Target-2.8.4

Comment #1 on issue 1632 by pekka.klarck: --suite option doesn't work when  
dot in filename and running folder

http://code.google.com/p/robotframework/issues/detail?id=1632

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--

--- 
You received this message because you are subscribed to the Google Groups "robotframework-commit" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to robotframework-commit+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.