I'm all for code reviews, but since we're all pressed for time, I doubt we can formalize the process. For the most part, I review code when I need to modify it - and I'll make sure and ask this list if I don't understand or have problems with it.
Of course, if you have time to do a code review - more power to ya! ;-) Matt On 8/2/05, Allen Gilliland <[EMAIL PROTECTED]> wrote: > Stemming from the discussion about code conventions, how would people feel > about having code reviews? > > I'm not thinking of anything formal, but I think it could be very beneficial > to have something like a code review when sizable chunks of code for new > features are added to the code base. I can't speak for others, but I really > like having my code reviewed so I can get feedback as well as ensure that my > new code fits with the best practices of the project. This also seems very > relevant in the case of an open source project since we don't all work very > closely together and may come from pretty varied backgrounds. > > Things that I like reviewing for are ... > > - were the right set of classes/objects defined to properly represent good OO > design? > - are the classes highly cohesive? > - were good naming conventions chosen? > - were classes placed in the proper packages? > - is the code properly commented > - are exceptions caught and thrown when appropriate > > I am thinking the process could be simple so that whenever you contribute > code for a new feature and feel that it's reasonably far along (and not > necessarily complete) you just send out and email asking for a quick code > review and name what classes you have added/modified. does anyone else think > this would be helpful? > > -- Allen > > >
