It seems as if the CC and WC macros are responsible for 'make dep' failing for us in some cases, since gcc won't detect that the structure is used over there..
So in near future i'm going to spread CCC and WCC a little more.
Perhaps we can find a better way of automating it?
I suppose we could just eliminate the #define entirely, and then every place
we need CC we could just do
struct CitContext *CC = MyContext();
That's a lot of noise, of course, but if you're going to put struct CitContext
*CCC = CC;
r8719 | ajc | 2010-07-27 10:12:07 -0400 (Tue, 27 Jul 2010) | 1 line
Changed paths:
M /trunk/citadel/clientsocket.c
M /trunk/citadel/context.c
M /trunk/citadel/msgbase.c
M /trunk/citadel/sysdep.c
M
I think the define is OK, there just should be a CCC which is set once, so the compiler can actualy see a pointer to CitContext so it can correctly enlist it in the dependency list
the CCC also gives you a chance to have easy access to it once you're in gdb and wanting to watch some of its members.
else you'll have to go up to some obscure frame, find out some obscure function local pointer, get your CC pointer thereof and watch your stuff there.
Real inconvenient in
r8720 | dothebart | 2010-07-27 16:03:02 -0400 (Tue, 27 Jul 2010) | 1 line
Changed paths:
M /branches/stable-78x/citadel/threads.c
M /trunk/citadel/threads.c
* ctdl_internal_thread_func(): just use SYS_gettid if the
r8721 | dothebart | 2010-07-27 18:50:33 -0400 (Tue, 27 Jul 2010) | 3 lines
Changed paths:
M /trunk/webcit/subst.c
* LogTemplateError(): allow referencing random tokens for the [] at the start
of the errormessage.
*
r8723 | dothebart | 2010-07-27 18:50:50 -0400 (Tue, 27 Jul 2010) | 1 line
Changed paths:
M /trunk/webcit/static/t/room/edit/er_config_tab_room_option_list.html
A /trunk/webcit/static/t/room/edit/submit.html
M
r8722 | dothebart | 2010-07-27 18:50:43 -0400 (Tue, 27 Jul 2010) | 1 line
Changed paths:
M /trunk/webcit/subst.c
* tmpl_iterate_subtmpl(): we now enter this function with
TP-Tokens-nParameters being one bigger
r8724 | ajc | 2010-07-27 23:06:12 -0400 (Tue, 27 Jul 2010) | 1 line
Changed paths:
M /branches/stable-78x/citadel/msgbase.c
M /trunk/citadel/msgbase.c
* When outputting legacy Citadel format messages, stop only when we
10 matches
Mail list logo
