This looks hackish
It also breaks the log as you're potentially returning something different from
what the log states
-Original Message-
From: ros-diffs-boun...@reactos.org [mailto:ros-diffs-boun...@reactos.org] On
Behalf Of cgut...@svn.reactos.org
Sent: 06 July 2009 08:54
To:
It's not a hack. We know we have succeded if we reach that code
because we check for failure earlier. The problem is that status was
the return value of DeviceIoControl which returns nonzero for success
but zero is success in ntstatus.
On Jul 6, 2009, at 4:44 AM, Ged gedmur...@gmail.com
Yeah, I should have stated this more clearly.
My point was DeviceIoControl returns TRUE, you then print this to the log as
an NTSTATUS value which now holds the value '1' which in NTSTATUS terms is
STATUS_WAIT_0 + 1
After this you then return STATUS_SUCCESS which is 0.
As I said, it's
Yeah, I need to fix those.
On Jul 6, 2009, at 4:39 PM, Timo Kreuzer timo.kreu...@web.de wrote:
The hack is storing a BOOL value in an NTSTATUS variable.
Cameron Gutman schrieb:
It's not a hack. We know we have succeded if we reach that code
because we check for failure earlier. The
