Re: [ros-dev] [ros-diffs] [cgutman] 53232: [NTOSKRNL] - Fix NULL termination of strings in IoGetDeviceProperty - Fixes garbage displayed in the Enumerator field of the device manager property page

2011-08-14 Thread Alex Ionescu
And, you have, of course, confirmed that this piece of kernel code is wrong, and that DevMgr/Cfgapi/SetupApi are doing the right thing, right? So if I was to reverse engineer ntoskrnl I wouldn't discover that it was actually doing the same thing as the un-fixed code, right? Best regards, Alex

Re: [ros-dev] [ros-diffs] [cgutman] 53232: [NTOSKRNL] - Fix NULL termination of strings in IoGetDeviceProperty - Fixes garbage displayed in the Enumerator field of the device manager property page

2011-08-14 Thread Cameron Gutman
Well, writing beyond the buffer length we were supplied to null terminate a string seems bad in my book ;) Cameron On Aug 14, 2011, at 11:00 AM, Alex Ionescu ion...@videotron.ca wrote: And, you have, of course, confirmed that this piece of kernel code is wrong, and that

Re: [ros-dev] [ros-diffs] [cgutman] 53232: [NTOSKRNL] - Fix NULL termination of strings in IoGetDeviceProperty - Fixes garbage displayed in the Enumerator field of the device manager property page

2011-08-14 Thread Timo Kreuzer
:D Am 14.08.2011 17:00, schrieb Alex Ionescu: And, you have, of course, confirmed that this piece of kernel code is wrong, and that DevMgr/Cfgapi/SetupApi are doing the right thing, right? So if I was to reverse engineer

Re: [ros-dev] [ros-diffs] [cgutman] 53232: [NTOSKRNL] - Fix NULL termination of strings in IoGetDeviceProperty - Fixes garbage displayed in the Enumerator field of the device manager property page

2011-08-14 Thread caemyr
This revision breaks up MSVC iso booting: http://www.reactos.org/paste/index.php/9231/ -- With best regards Caemyr ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev