Re: [ros-dev] [ros-diffs] [cgutman] 59704: [CMAKE] - Define i386 on x86 MSVC builds - Probably fixes the infamous MSVC networking issues caused by tcpip.h assuming it was a big-endian platform and nev

2013-08-12 Thread Timo Kreuzer
I remember some time ago, I ran into a problem with i386 definition somewhere, because it was used in a structure or something. I would prefer to use standard definitions as much as possible. And in the case of Windows code, I would consider MS to be standard. So IMO we should use _X86_ or _M_IX86

Re: [ros-dev] [ros-diffs] [cgutman] 59704: [CMAKE] - Define i386 on x86 MSVC builds - Probably fixes the infamous MSVC networking issues caused by tcpip.h assuming it was a big-endian platform and nev

2013-08-12 Thread Cameron Gutman
My original plan was to switch to a different definition, but at least one MS header (netiodef.h in WDK 8.0) uses i386 too. On 8/12/2013 1:04 AM, Timo Kreuzer wrote: I remember some time ago, I ran into a problem with i386 definition somewhere, because it was used in a structure or something.