Re: [ros-dev] [ros-diffs] [reactos] 01/01: CID 1206831 Dereference after null check

2017-10-31 Thread Thomas Faber
Or the annotation is just wrong and this parameter is not optional? On 2017-10-31 16:07, encoded wrote: Seems like this API has a 'feature' where by it throws exceptions if BytesRead is null? On Sun, Oct 29, 2017 at 8:02 AM, Jerome Gardou wrote: HI, that doesn't look good, as shown by http

Re: [ros-dev] [ros-diffs] [reactos] 01/01: CID 1206831 Dereference after null check

2017-10-31 Thread hermes . belusca
27;s just your fault if your app crashes. And of course, since ReactOS also want to behave similarly... we don't check for NULL either! H. De : A : ros-dev@reactos.org Envoyé: mardi 31 octobre 2017 16:10 Objet : Re: [ros-dev] [ros-diffs] [reactos] 01/01: CID 1206831 Dereference after

Re: [ros-dev] [ros-diffs] [reactos] 01/01: CID 1206831 Dereference after null check

2017-10-31 Thread encoded
Seems like this API has a 'feature' where by it throws exceptions if BytesRead is null? On Sun, Oct 29, 2017 at 8:02 AM, Jerome Gardou wrote: > HI, > > that doesn't look good, as shown by https://reactos.org/testman/co > mpare.php?ids=56275,56276 > > Jérôme > > > Le 29/10/2017 à 11:17, Samuel Se

Re: [ros-dev] [ros-diffs] [reactos] 01/01: CID 1206831 Dereference after null check

2017-10-29 Thread Jerome Gardou
HI, that doesn't look good, as shown by https://reactos.org/testman/compare.php?ids=56275,56276 Jérôme Le 29/10/2017 à 11:17, Samuel Serapion a écrit : https://git.reactos.org/?p=reactos.git;a=commitdiff;h=b3b2a23f05e5188dc1475961fcd7f036f0046d25 commit b3b2a23f05e5188dc1475961fcd7f036f004