[ros-dev] RFC: Change Rapps 'Size' field

[Mark Jansen]

Hello,

I'd like to propose a change for the 'Size' field:
Currently this is a localized, pre-formatted field.
By changing this to the actual size in bytes:
- We can use StrFormatByteSizeW to format it locale dependent (without 
the need to manually translate it)
- We can use this value to display the progress bar, in case the 
download itself does not provide this value (for example, web.archive 
does not provide this).


For backwards compatibility we should probably add this as another 
field, so that the 'old' rapps can still read the 'Size' field.


Regards,

Mark


___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] RFC: Change Rapps 'Size' field

[Hermès BÉLUSCA-MAÏTO]

Two possibilities :

-  Either have : « Size = 1.345.123 » with no units, it’s in bytes, 
otherwise it is a string to be displayed. I wonder if that already breaks 
backwards compatibility with old versions of rapps… But then these old versions 
of rapps may or may not be able to connect to the new web service we are 
preparing for the databases? (in which case we don’t have to care too much 
about them)

-  Or just use some “ SizeInBytes = 1.345.123 ” field. It’s clear, and 
you just read that value and use the shell function you pointed in your 
previous mail to format it in MB or whatever.

 

Hermès

 

De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de David Quintana 
(gigaherz)
Envoyé : jeudi 8 février 2018 21:03
À : ReactOS Development List
Objet : Re: [ros-dev] RFC: Change Rapps 'Size' field

 

https://github.com/reactos/rapps-db/blob/master/7zip.txt#L6

 

On 8 February 2018 at 21:00, Hermès BÉLUSCA-MAÏTO  wrote:

What 'size' field are you exactly talking about?

> -Message d'origine-
> De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Mark Jansen
> Envoyé : jeudi 8 février 2018 20:43
> À : ros-dev@reactos.org
> Objet : [ros-dev] RFC: Change Rapps 'Size' field

>
> Hello,
>
> I'd like to propose a change for the 'Size' field:
> Currently this is a localized, pre-formatted field.
> By changing this to the actual size in bytes:
> - We can use StrFormatByteSizeW to format it locale dependent (without the
> need to manually translate it)
> - We can use this value to display the progress bar, in case the download 
> itself
> does not provide this value (for example, web.archive does not provide this).
>
> For backwards compatibility we should probably add this as another field, so
> that the 'old' rapps can still read the 'Size' field.
>
> Regards,
>
> Mark
>
>
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev


___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

 

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] RFC: Change Rapps 'Size' field

[Hermès BÉLUSCA-MAÏTO]

What 'size' field are you exactly talking about?

> -Message d'origine-
> De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Mark Jansen
> Envoyé : jeudi 8 février 2018 20:43
> À : ros-dev@reactos.org
> Objet : [ros-dev] RFC: Change Rapps 'Size' field
> 
> Hello,
> 
> I'd like to propose a change for the 'Size' field:
> Currently this is a localized, pre-formatted field.
> By changing this to the actual size in bytes:
> - We can use StrFormatByteSizeW to format it locale dependent (without the
> need to manually translate it)
> - We can use this value to display the progress bar, in case the download 
> itself
> does not provide this value (for example, web.archive does not provide this).
> 
> For backwards compatibility we should probably add this as another field, so
> that the 'old' rapps can still read the 'Size' field.
> 
> Regards,
> 
> Mark
> 
> 
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev


___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] RFC: Change Rapps 'Size' field

[David Quintana (gigaherz)]

https://github.com/reactos/rapps-db/blob/master/7zip.txt#L6

On 8 February 2018 at 21:00, Hermès BÉLUSCA-MAÏTO 
wrote:

> What 'size' field are you exactly talking about?
>
> > -Message d'origine-
> > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Mark
> Jansen
> > Envoyé : jeudi 8 février 2018 20:43
> > À : ros-dev@reactos.org
> > Objet : [ros-dev] RFC: Change Rapps 'Size' field
> >
> > Hello,
> >
> > I'd like to propose a change for the 'Size' field:
> > Currently this is a localized, pre-formatted field.
> > By changing this to the actual size in bytes:
> > - We can use StrFormatByteSizeW to format it locale dependent (without
> the
> > need to manually translate it)
> > - We can use this value to display the progress bar, in case the
> download itself
> > does not provide this value (for example, web.archive does not provide
> this).
> >
> > For backwards compatibility we should probably add this as another
> field, so
> > that the 'old' rapps can still read the 'Size' field.
> >
> > Regards,
> >
> > Mark
> >
> >
> > ___
> > Ros-dev mailing list
> > Ros-dev@reactos.org
> > http://www.reactos.org/mailman/listinfo/ros-dev
>
>
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

[Thomas Faber]

On 2018-02-08 01:55, Alex Ionescu wrote:

This changes documented/external behavior. What is the point of this change?


Hmm. Before approving the change I googled/tested whether Windows
produces that output but somehow didn't see it. Now that you mention it,
all versions of Windows do seem to have that exact print, so I agree we
should revert this to avoid breaking tools that scan the debug output.

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

[Pierre Schweitzer]

Hey Alex,

The root cause of this is:
https://jira.reactos.org/browse/CORE-14293?focusedCommentId=101589=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-101589

Cheers,
Pierre

Le 08/02/2018 à 01:55, Alex Ionescu a écrit :
> This changes documented/external behavior. What is the point of this change?
> Best regards,
> Alex Ionescu
> 
> 
> On Wed, Feb 7, 2018 at 1:22 PM, Serge Gautherie
>  wrote:
>> https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6ece4e9fc22d664ea2485d04303e8ae10047f21f
>>
>> commit 6ece4e9fc22d664ea2485d04303e8ae10047f21f
>> Author: Serge Gautherie 
>> AuthorDate: Wed Feb 7 06:29:02 2018 +0100
>> Commit: Pierre Schweitzer 
>> CommitDate: Wed Feb 7 22:22:28 2018 +0100
>>
>> [NTOS:KE] Replace "Fatal System Error" with "BugCheck"
>> ---
>>  ntoskrnl/ke/bug.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/ntoskrnl/ke/bug.c b/ntoskrnl/ke/bug.c
>> index a92acb1bab..2127d7207c 100644
>> --- a/ntoskrnl/ke/bug.c
>> +++ b/ntoskrnl/ke/bug.c
>> @@ -1070,8 +1070,8 @@ KeBugCheckWithTf(IN ULONG BugCheckCode,
>>  if ((BugCheckCode != MANUALLY_INITIATED_CRASH) && (KdDebuggerEnabled))
>>  {
>>  /* Crash on the debugger console */
>> -DbgPrint("\n*** Fatal System Error: 0x%08lx\n"
>> - "   (0x%p,0x%p,0x%p,0x%p)\n\n",
>> +DbgPrint("\n*** BugCheck: 0x%08lx\n"
>> + " (0x%p,0x%p,0x%p,0x%p)\n\n",
>>   KiBugCheckData[0],
>>   KiBugCheckData[1],
>>   KiBugCheckData[2],
>>
> 
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
> 


-- 
Pierre Schweitzer 
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.



signature.asc
Description: OpenPGP digital signature
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

[Pierre Schweitzer]

Done with e26e4445b39d7455e83e45ac7272d21289cc5106.

Le 08/02/2018 à 11:29, Thomas Faber a écrit :
> On 2018-02-08 01:55, Alex Ionescu wrote:
>> This changes documented/external behavior. What is the point of this
>> change?
> 
> Hmm. Before approving the change I googled/tested whether Windows
> produces that output but somehow didn't see it. Now that you mention it,
> all versions of Windows do seem to have that exact print, so I agree we
> should revert this to avoid breaking tools that scan the debug output.
> 
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev


-- 
Pierre Schweitzer 
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.



signature.asc
Description: OpenPGP digital signature
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev