[ros-dev] [ros-diffs] [tfaber] 60231: [NPFS] - Release cancel spinlock in NpCancelListeningQueueIrp

2013-09-20 Thread Hermès BÉLUSCA - MAÏTO
I think a call to IoReleaseCancelSpinLock should be balanced with a call to IoAcquireCancelSpinLock somewhere in the npfs_new code, however, looking at: http://git.reactos.org/?p=reactos.git http://git.reactos.org/?p=reactos.gita=searchh=HEADst=greps=IoAcquireCa ncelSpinLock

Re: [ros-dev] [ros-diffs] [tfaber] 60231: [NPFS] - Release cancel spinlock in NpCancelListeningQueueIrp

2013-09-20 Thread Thomas Faber
Yay someone actually reviewing code :D Cancel routines are called with the cancel spinlock held and must release it at some point during their execution. http://msdn.microsoft.com/en-us/library/windows/hardware/ff540742(v=vs.85).aspx On 2013-09-20 11:53, Hermès BÉLUSCA - MAÏTO wrote: I think a

Re: [ros-dev] [SPAM]Re: [ros-diffs] [tfaber] 60231: [NPFS] - Release cancel spinlock in NpCancelListeningQueueIrp

2013-09-20 Thread Hermès BÉLUSCA - MAÏTO
Cancel routines are called with the cancel spinlock held and must release it at some point during their execution. http://msdn.microsoft.com/en-us/library/windows/hardware/ff540742(v=vs.85).aspx Ok, nice to know, thanks Thomas :) Hermès -Message d'origine- De :

Re: [ros-dev] [ros-diffs] [hbelusca] 60250: [KERNEL32]: Reenable two dprints to be able to know how programs are launched with which parameters and so on...

2013-09-20 Thread Alex Ionescu
Please don't do this. There's no reason this has to be on for all applications, and it wasn't before. Use DbgPrintEx for this and setup your filter in the debugger/KDBG appropriately. Best regards, Alex Ionescu On Fri, Sep 20, 2013 at 6:12 PM, hbelu...@svn.reactos.org wrote: Author: hbelusca

Re: [ros-dev] [ros-diffs] [hbelusca] 60250: [KERNEL32]: Reenable two dprints to be able to know how programs are launched with which parameters and so on...

2013-09-20 Thread Hermès BÉLUSCA - MAÏTO
Well, it’s to check something on the test bots (both the linux and the windows ones)… (the two dprints will be disabled again after). De : ros-dev-boun...@reactos.org [mailto:ros-dev-boun...@reactos.org] De la part de Alex Ionescu Envoyé : samedi 21 septembre 2013 01:00 À : ReactOS Development