Hello,
I'd like to propose a change for the 'Size' field:
Currently this is a localized, pre-formatted field.
By changing this to the actual size in bytes:
- We can use StrFormatByteSizeW to format it locale dependent (without
the need to manually translate it)
- We can use this value to
Two possibilities :
- Either have : « Size = 1.345.123 » with no units, it’s in bytes,
otherwise it is a string to be displayed. I wonder if that already breaks
backwards compatibility with old versions of rapps… But then these old versions
of rapps may or may not be able to connect
What 'size' field are you exactly talking about?
> -Message d'origine-
> De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Mark Jansen
> Envoyé : jeudi 8 février 2018 20:43
> À : ros-dev@reactos.org
> Objet : [ros-dev] RFC: Change Rapps 'Size' field
>
> Hello,
>
> I'd like
https://github.com/reactos/rapps-db/blob/master/7zip.txt#L6
On 8 February 2018 at 21:00, Hermès BÉLUSCA-MAÏTO
wrote:
> What 'size' field are you exactly talking about?
>
> > -Message d'origine-
> > De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de
On 2018-02-08 01:55, Alex Ionescu wrote:
This changes documented/external behavior. What is the point of this change?
Hmm. Before approving the change I googled/tested whether Windows
produces that output but somehow didn't see it. Now that you mention it,
all versions of Windows do seem to
Hey Alex,
The root cause of this is:
https://jira.reactos.org/browse/CORE-14293?focusedCommentId=101589=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-101589
Cheers,
Pierre
Le 08/02/2018 à 01:55, Alex Ionescu a écrit :
> This changes documented/external behavior.
Done with e26e4445b39d7455e83e45ac7272d21289cc5106.
Le 08/02/2018 à 11:29, Thomas Faber a écrit :
> On 2018-02-08 01:55, Alex Ionescu wrote:
>> This changes documented/external behavior. What is the point of this
>> change?
>
> Hmm. Before approving the change I googled/tested whether Windows
>