Hi,
I guess I don't have to introduce myself all that much anymore ;)
Please see [1] if you disagree.
I plan to submit a GSoC project proposal concerning the kernel-mode
test suite, and would like to discuss a few key points to better shape
the project idea and its timeline.
Because of the
On 2011-09-03 20:07, Timo Kreuzer wrote:
Am 03.09.2011 13:14, schrieb Alex Ionescu:
--- trunk/reactos/dll/win32/browseui/bandsite.cpp [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/browseui/bandsite.cpp [iso-8859-1] Thu Sep 1
15:30:19 2011
@@ -719,7 +719,7 @@
if (fRebarWindow ==
Hi,
I've been looking at VirtualBox 4.1.x guest additions, which don't install
in ROS [1] and came up with a patch [2] that seems to fix them.
While patchbot says this is okay [3] (and the last hunk even fixes a few
setupapi tests), I am very unsure about the SP_COPY_NOOVERWRITE part.
The
On 2011-11-17 12:07, Timo Kreuzer wrote:
Am 16.11.2011 22:17, schrieb tfa...@svn.reactos.org:
-#define SharedUserData ((KUSER_SHARED_DATA
*CONST)USER_SHARED_DATA)
+#define SharedUserData ((KUSER_SHARED_DATA
*)USER_SHARED_DATA)
It is like this (with the
On 2011-11-18 09:08, Cameron Gutman wrote:
On Nov 17, 2011, at 7:07 PM, James Tabor wrote:
Head up on this one. It's recoverable by just typing cont and it goes on.
(dll/ntdll/ldr/ldrutils.c:1177) Overlapping DLL:
C:\ReactOS\system32\oleaut32.dll
WARNING: MmFlushVirtualMemory at
Hey,
On 2011-12-31 15:33, jgar...@svn.reactos.org wrote:
Author: jgardou
Date: Sat Dec 31 14:33:35 2011
New Revision: 54793
URL: http://svn.reactos.org/svn/reactos?rev=54793view=rev
Log:
[NEWINFLIB]
- use _snwprintf instead of swprintf (MSVC is not compliant with standard
here)
since
Hey Jérôme,
On 2012-02-21 01:40, Jérôme Gardou wrote:
Le 21/02/2012 01:32, jgar...@svn.reactos.org a écrit :
Author: jgardou
Date: Tue Feb 21 00:32:24 2012
New Revision: 55770
URL: http://svn.reactos.org/svn/reactos?rev=55770view=rev
Log:
[NTOSKRNL/MM]
- finally, release user shared
On 2012-03-14 11:21, Javier Agustìn Fernàndez Arroyo wrote:
Shouldn´t have you done this in the CTL2012 branch instead of trunk?
Hey, don't scare me! ;)
In SVN, branches are usually in a subdirectory of the same repository.
That is, trunk is /trunk, branches are inside /branches and tags are
Hi,
I've noticed that the ROS-Diffs list (or rather the hook sending to it)
consistently fails on revisions that have special chars in their commit
message.
E.g. there is no message for r56846, r56844, r56763, r56754 etc.
(sorry Hermès :p)
This goes back as far as r23711 (August 2006), for which
Hey,
On 2012-08-18 23:40, jimta...@svn.reactos.org wrote:
URL:http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/caret.c?rev=57101r1=57100r2=57101view=diff
==
---
, all source files include it before wined3d_private.h. It's just
that our wined3d is slightly outdated. A sync would permanently solve
this issue.
Cheers!
Jérôme.
Thomas Faber a écrit :
Hi,
On 2012-08-21 15:38, jgar...@svn.reactos.org wrote:
URL:http://svn.reactos.org/svn/reactos?rev=57124view
Hi,
On 2012-08-26 11:17, jgar...@svn.reactos.org wrote:
Log:
[OPENGL32_WINETEST]
- Sync with wine
speaking from previous experience, it'd be very nice if the commit
message would allow finding the correctly matched Wine version for this
easily (i.e. without tedious look-up of what was HEAD on
Hey,
I can't make it today, but I have some points that I think need to be
addressed nonetheless:
- next round of developer contracts
- state of trunk (in one word: excellent) and plans for the next
release (i.e. expected features/fixes, optionally a schedule)
[seeing people try to use
Hi!
On 02.09.2012 03:17, i...@svn.reactos.org wrote:
Modified: trunk/reactos/ntoskrnl/mm/ARM3/virtual.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/virtual.c?rev=57215r1=57214r2=57215view=diff
Hi,
On 2012-08-29 14:28, mnord...@svn.reactos.org wrote:
--- trunk/reactos/subsystems/csr/csrsrv/process.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/csr/csrsrv/process.c [iso-8859-1] Wed Aug 29
12:28:35 2012
@@ -1211,7 +1211,7 @@
BOOLEAN FirstTry;
ULONG i;
Hey Pavel,
it's great to hear that you find ReactOS useful for developing you
driver!
It's also excellent to have another driver confirmed working. ;)
On 2012-09-10 00:11, Pavel Pisa wrote:
The issues:
1) the first minor one - ReactOS requires minimal transfer size for
Hey,
some random thoughts:
- bugs are sometimes related to the build system (e.g. patches for
cmake files), so that might be a more generalized version of
host-tools
- shell seems rather broad if it's supposed to include both explorer
(+dlls) and cmd
- services.exe, svchost, and actual
After some more discussion, here's another concrete proposal...
Issue types:
(go from top to bottom when deciding which to use)
Patch = A concrete code change that should be discussed/reviewed/tested
Unimplemented = Windows has this, we don't
Bug = Something is broken and should be
Hermès' Updated Yesterday filter looks like it has the answer:
(updated = startOfDay(-1d) AND updated = endOfDay(-1d)) ORDER BY created
DESC, key DESC
So I'd do older than 1 year as:
created = startOfDay(-1y) ORDER BY created DESC
On 2012-09-13 11:28, Timo Kreuzer wrote:
Hi,
Does anyone
On 2012-09-13 02:52, mnord...@svn.reactos.org wrote:
--- trunk/reactos/subsystems/csr/csrsrv/process.c [iso-8859-1] (original)
+++ trunk/reactos/subsystems/csr/csrsrv/process.c [iso-8859-1] Thu Sep 13
00:52:12 2012
@@ -1211,7 +1211,7 @@
BOOLEAN FirstTry;
ULONG i;
On 2012-09-17 01:48, Timo Kreuzer wrote:
Amd64 doesn't need a frame pointer. Backtraces are made based on unwind
tables. At least if GCC conforms to the ABI.
That's why the option was removed. It doesn't do anything anyway ;)
Any form of -O implies -fomit-frame-pointer on AMD64 AFAIK.
Yeah, that would certainly be a more sensible convention.
I wasn't planning on refactoring all of shell32 any time soon though. :|
We accept patches™ ;)
On 2012-10-05 10:30, Timo Kreuzer wrote:
Shouldn't member variables rather be prefixed with m_?
Am 05.10.2012 01:46, schrieb
I'm integrating greenie's changes to allow Edijus to continue working on
explorer-new.
There was a code review,
http://code.reactos.org/cru/CR-14
to which nobody seemed to have any objections, and testing says it works
better than before - so we figured future work should be based on the
project
VS has them in VC\include rather than SDK\x.x\include.
They classify this as compiler support for COM.
On 2013-01-29 10:17, Timo Kreuzer wrote:
comdef friends are not crt headers, they should go to psdk.
Am 26.01.2013 14:33, schrieb tfa...@svn.reactos.org:
Author: tfaber
Date: Sat Jan
Hey Eric,
On 2013-02-17 02:06, ek...@svn.reactos.org wrote:
Modified: trunk/reactos/dll/win32/msgina/msgina.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msgina/msgina.c?rev=58326r1=58325r2=58326view=diff
Kohl wrote:
Hello Thomas,
r58329 fixes the VMPlayer-Test but the VBox-Test still fails.
Unfortunately, the stdio log of the VBox-Test does not provied any
useful information.
Regards
Eric
Am 17.02.2013 13:12, schrieb Thomas Faber:
Hey Eric,
On 2013-02-17 02:06, ek
We accept patches™.
Also, the SVN log provides a little description of why it's the way it
is:
http://svn.reactos.org/svn/reactos?view=revisionrevision=50473
On 2013-05-05 18:25, J. C. Jones wrote:
Salut,
Since there already exists commands for getting the date via the
command-line
Your problem was trying to sync with /reactos/trunk/ while the branch
was created from /reactos/trunk/reactos/. Have a look at the folder
structure in a web browser or Tortoise's Repository Browser to see
the difference.
I've recreated it from /reactos/trunk/, as should be the default.
On
On 2013-09-18 01:02, hbelu...@svn.reactos.org wrote:
Added:
branches/ntvdm/lib/soft386/common.inl (with props)
It's a header file. Can you name it .h please to not break syntax
highlight? Thanks.
___
Ros-dev mailing list
Ros-dev@reactos.org
Yay someone actually reviewing code :D
Cancel routines are called with the cancel spinlock held and must
release it at some point during their execution.
http://msdn.microsoft.com/en-us/library/windows/hardware/ff540742(v=vs.85).aspx
On 2013-09-20 11:53, Hermès BÉLUSCA - MAÏTO wrote:
I think a
On 2013-10-09 02:41, Hermès BÉLUSCA - MAÏTO wrote:
c++-bringup
Very promising name and just one commit by jgardou, 8th of March, 2012.
We can already compile c++ things with GCC / MSVC now, iirc.
So, candidate for deletion?
We should ask Amine and Thomas and Timo :)
It's already deleted ;)
On 2013-10-16 00:14, jimta...@svn.reactos.org wrote:
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/windows/prop.c?rev=60682r1=60681r2=60682view=diff
==
---
It's C++ :)
On 2013-11-07 23:23, Timo Kreuzer wrote:
This looks like MSVC won't like it.
Am 07.11.2013 15:14, schrieb gadamopou...@svn.reactos.org:
GetModuleFileNameW(hInstance, swShell32Name, MAX_PATH);
swShell32Name[MAX_PATH - 1] = '\0';
-
This is intentional, their RTL_ATOM_TABLE is already a pointer:
/* Wine doesn't implement atom table as NT does:
* - in NT, atom tables are user space tables, which ntdll directly accesses
* - on Wine, (even local) atom tables are wineserver objects, hence a HANDLE
*/
typedef struct atom_table
That's illegal, macros can't be overloaded.
drivers/filesystems/ext2/inc/ext2fsd.h:64:0: warning: try_return redefined
[enabled by default]
You could try
#define try_return(...) { __VA_ARGS__; goto try_exit; }
If that doesn't do it, it might simply need a separate macro
(I'm not sure to what
at this point.
On 2014-03-25 02:20, Hermès BÉLUSCA - MAÏTO wrote:
Hmmm also, is there any C error code associated with that, on MSVC ?
-Message d'origine-
De : ros-dev-boun...@reactos.org [mailto:ros-dev-boun...@reactos.org] De la
part de Thomas Faber
Envoyé : lundi 24 mars 2014 23
You guys should consider replacing that stuff with strsafe functions
while you're at it ;)
On 2014-04-06 18:45, khorni...@svn.reactos.org wrote:
Author: khornicek
Date: Sun Apr 6 16:45:21 2014
New Revision: 62665
URL: http://svn.reactos.org/svn/reactos?rev=62665view=rev
Log:
[MAIN]
-
tests in
form of a loop :)
-Message d'origine-
De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Faber
Envoyé : dimanche 6 avril 2014 18:10
À : ros-dev@reactos.org
Objet : Re: [ros-dev] [ros-diffs] [hbelusca] 62662: [NTDLL_APITEST]: Add
braces and remove an unneeded
On 2014-04-07 07:58, Pierre Schweitzer wrote:
My (naive) guess, would be as I did on CDFS: copy len - 1 and 0 last char.
StringCbCopyW will do just that :)
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev
On 2014-04-18 23:40, pschweit...@svn.reactos.org wrote:
--- trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] Fri Apr 18
21:40:02 2014
@@ -129,7 +131,7 @@
BOOLEAN
CdfsFCBIsRoot(PFCB Fcb)
{
-
On 2014-04-22 22:46, aandreje...@svn.reactos.org wrote:
--- branches/ntvdm/subsystems/ntvdm/ntvdm.c [iso-8859-1] (original)
+++ branches/ntvdm/subsystems/ntvdm/ntvdm.c [iso-8859-1] Tue Apr 22
20:46:50 2014
@@ -196,6 +197,11 @@
EmulatorInterrupt(0x23);
break;
Jim, this introduced a new warning:
win32ss/user/user32/windows/menu.c:1952:14: warning: comparison of unsigned
expression 0 is always false [-Wtype-limits]
Thanks.
On 2014-04-28 08:40, jimta...@svn.reactos.org wrote:
Author: jimtabor
Date: Mon Apr 28 03:55:23 2014
New Revision: 63027
Uh, this is missing the Patch by Víctor Martínez part, sorry.
On 2014-04-28 10:27, tfa...@svn.reactos.org wrote:
Author: tfaber
Date: Mon Apr 28 08:27:57 2014
New Revision: 63032
URL: http://svn.reactos.org/svn/reactos?rev=63032view=rev
Log:
[NETCFGX]
- Use correct parent key instead of
On 2014-04-29 13:14, dquint...@svn.reactos.org wrote:
[SHELL32]
* Make use of IID_NULL_PPV_ARG in all the calls to GetUIObjectOf, and fix one
instance of mismatched riid/pointer.
I don't see that mismatch. What am I missing? ;)
___
Ros-dev mailing
Woohoo, thanks!
Questions/comments inline.
On 2014-05-12 01:11, tkreu...@svn.reactos.org wrote:
--- trunk/reactos/include/ddk/ntifs.h [iso-8859-1] (original)
+++ trunk/reactos/include/ddk/ntifs.h [iso-8859-1] Sun May 11 23:11:16 2014
@@ -870,11 +870,11 @@
(NTAPI *PRTL_FREE_STRING_ROUTINE)(
Hrm, why not just limit the define to C instead?
On 2014-05-18 16:39, akha...@svn.reactos.org wrote:
Author: akhaldi
Date: Sun May 18 14:39:03 2014
New Revision: 63353
URL: http://svn.reactos.org/svn/reactos?rev=63353view=rev
Log:
[CMAKE/MSVC]
* Define _ALLOW_KEYWORD_MACROS to get the
--- trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/shlexec.cpp [iso-8859-1] Fri May 23
17:14:39 2014
@@ -459,7 +459,7 @@
startup.dwFlags = STARTF_USESHOWWINDOW;
startup.wShowWindow = psei-nShow;
von Wittich wrote:
This should be send to wine then.
-Ursprüngliche Nachricht-
Von: Ros-dev [mailto:ros-dev-boun...@reactos.org] Im Auftrag von Thomas
Faber
Gesendet: Samstag, 24. Mai 2014 11:03
An: ros-dev@reactos.org
Betreff: Re: [ros-dev] [ros-diffs] [cwittich] 63423: [shell32
This is not the right solution. SVN has terrible UTF-16 handling so we
should not convert these back to UTF-16.
https://jira.reactos.org/browse/CORE-7703
https://jira.reactos.org/browse/CORE-8221
On 2014-05-25 22:17, cwitt...@svn.reactos.org wrote:
Author: cwittich
Date: Sun May 25 20:17:25
The savior, as always.
Thank you!
On 2014-05-27 21:42, akha...@svn.reactos.org wrote:
Author: akhaldi
Date: Tue May 27 19:42:15 2014
New Revision: 63480
URL: http://svn.reactos.org/svn/reactos?rev=63480view=rev
Log:
[CMAKE]
* Convert the hives from UTF-8 to UTF16 as part of the build
On 2014-05-20 23:11, tkreu...@svn.reactos.org wrote:
--- trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] Tue May 20
21:11:43 2014
@@ -4593,8 +4593,8 @@
// on the user input, and then compute the actual region
This helps find logic errors, mostly where the programmer thought the
variable was signed but it's actually unsigned, e.g. if (ret 0) for a
function that returns (ULONG)-1.
I also don't see how the fix would be complicated in most cases.
(x = 0) becomes (x == 0), (x 0) becomes (x == (ULONG)-1)
2014 um 12:49 Uhr
*Von:* Thomas Faber thomas.fa...@reactos.org
*An:* ros-dev@reactos.org
*Betreff:* Re: [ros-dev] [ros-diffs] [tkreuzer] 63520: [MCISEQ] Silence a
warning [CMAKE] Get rid of -Wtype-limits, it's noisy, it doesn't provide any
reasonable benefit and it's almost impossible to fix
On 2014-06-25 09:10, Vyronas Tsingaras wrote:
Is this patch acceptable? Please kindly explain any possible mistakes.
The change to a wide character literal is correct, but a minor issue,
as these are identical integer values. To make the change consistent,
ptrTab =
On 2014-08-04 18:25, hbelu...@svn.reactos.org wrote:
[KERNEL32]
Add a bunch of missing _SEH_YIELD in 'return' clues in _SEH_TRY clauses.
That should be pointless with PSEH3. I believe Timo has in fact been
removing them.
___
Ros-dev mailing list
On 2014-08-14 22:10, hbelu...@svn.reactos.org wrote:
+if (FaceName != GuiData-GuiInfo.FaceName)
+{
+SIZE_T Length = min(wcslen(FaceName) + 1, LF_FACESIZE); // wcsnlen
+wcsncpy(GuiData-GuiInfo.FaceName, FaceName, LF_FACESIZE);
+GuiData-GuiInfo.FaceName[Length] =
On 2014-08-24 17:40, hbelu...@svn.reactos.org wrote:
+mciSendCommand(wDeviceId, MCI_PUT,
MCI_DGV_PUT_DESTINATION | MCI_DGV_RECT | MCI_WAIT, (DWORD)mciPut);
A DWORD cannot fit a pointer. This function takes DWORD_PTR.
___
Ros-dev
On 2014-08-24 15:28, jgar...@svn.reactos.org wrote:
-// FT_Set_Pixel_Sizes(ft_face,
-// TextObj-logfont.elfEnumLogfontEx.elfLogFont.lfWidth,
+FT_Set_Pixel_Sizes(ft_face,
+ TextObj-logfont.elfEnumLogfontEx.elfLogFont.lfWidth,
The abs() was added
I can add them, but I thought PSEH2 was dead, yes.
On 2014-08-24 12:04, Jérôme Gardou wrote:
Hey Thomas
I think that you want to use _SEH2_YIELD in a few places here, that is,
unless we want to completely ditch pseh2 in favor of pseh3 ;-)
Regards
Jérôme
I've tracked down what happens on Windows in the debugger, and the
relevant device objects don't have DO_DIRECT_IO set.
The WDK sample FS drivers use neither I/O as well.
I'm not 100% sure but from what I saw this part of our I/O manager
implementation is identical to Windows's and there's no
Making the member conditional but writing to it unconditionally seems
like it would overflow the stack variable on GCC?
On 2014-09-07 23:40, tkreu...@svn.reactos.org wrote:
+#ifdef __clang__
+void *ReturnAddress;
#endif
+/* Safe the return address */
+mov ebx, [esp]
+mov
On 2014-09-07 23:40, tkreu...@svn.reactos.org wrote:
--- trunk/reactos/lib/pseh/i386/pseh3_i386.S [iso-8859-1] (original)
+++ trunk/reactos/lib/pseh/i386/pseh3_i386.S [iso-8859-1] Sun Sep 7
21:40:07 2014
@@ -30,6 +30,10 @@
mov [eax + SEH3_REGISTRATION_FRAME_Esi], esi
mov [eax +
On 2014-10-02 09:30, tkreu...@svn.reactos.org wrote:
-add_executable(dllimport_test
+add_library(dllimport_test
dllimport_framedyn.cpp)
Isn't the point of this test to check for linker errors?
___
Ros-dev mailing list
Ros-dev@reactos.org
On 2014-10-08 21:32, pschweit...@svn.reactos.org wrote:
+MftRecord = ExAllocatePoolWithTag(NonPagedPool,
+ Vcb-NtfsInfo.BytesPerFileRecord,
+ TAG_NTFS);
+if (MftRecord == NULL)
+{
+return NULL;
+
It's there for Wine compatibility. Things we would put in NDK, they put
in winternl.h.
On 2014-10-15 19:08, Ged Murphy wrote:
There shouldn't really be anything using this header
-Original Message-
From: Ros-diffs [mailto:ros-diffs-boun...@reactos.org] On Behalf Of
On 2014-10-15 22:23, pschweit...@svn.reactos.org wrote:
+/* See:
+ - http://msdn.microsoft.com/en-us/library/ms724228
+ - http://bos.asmhackers.net/docs/filesystems/ntfs/standard.html#layout
+ */
+VOID
+NtfsDateTimeToFileTime(ULONGLONG NtfsTime,
+ PLARGE_INTEGER
On 2014-10-12 21:37, Colin Finck wrote:
tfa...@svn.reactos.org wrote:
-DbgPrint(DbgString);
+OutputDebugStringA(DbgString);
FYI, we had OutputDebugStringA there in the first place, but I changed
it to DbgPrint in r40147.
IIRC, output from DbgPrint was
RtlEqualUnicodeString is in a pagable code section in ntoskrnl,
RtlCompareMemory is not. Holding a spinlock means we're at
DISPATCH_LEVEL and can't access pagable code/data.
On 2014-10-16 19:32, Hermès BÉLUSCA - MAÏTO wrote:
What is the *root* reason for this problem (ok I’ve seen in the
for it. There is no need for
it.
Am 15.10.2014 19:11, schrieb Thomas Faber:
It's there for Wine compatibility. Things we would put in NDK, they
put in winternl.h.
On 2014-10-15 19:08, Ged Murphy wrote:
There shouldn't really be anything using this header
-Original Message-
From: Ros-diffs
probably also kill the asm file for it. There is no need for
it.
Am 15.10.2014 19:11, schrieb Thomas Faber:
It's there for Wine compatibility. Things we would put in NDK, they
put in winternl.h.
On 2014-10-15 19:08, Ged Murphy wrote:
There shouldn't really be anything using this header
On 2014-10-18 01:28, akha...@svn.reactos.org wrote:
[CMAKE]
* Make the minimum required version 2.8.
As Víctor just found out the hard way, using target_include_directories
makes our minimum version 2.8.11. Should we set that as the minimum to
create a more obvious error message?
Current
On 2014-10-23 11:32, jgar...@svn.reactos.org wrote:
-if ( dwFileSize (sizeof(*dir) +
sizeof(dir-idEntries[0])*(dir-idCount-1)) )
+if (dwFileSize (sizeof(*dir) + FIELD_OFFSET(CURSORICONFILEDIR,
idEntries[dir-idCount])))
Did you mean to remove the sizeof(*dir)?
On 2014-10-29 19:11, Colin Finck wrote:
What's still not working is ReactOS itself though:
* bootcd works well, but bootcdregtest doesn't boot up at all, see
http://build.reactos.org/builders/Carrier-Win7%20VBox-Testbot/builds/43/steps/test/logs/stdio
I've put up this bootcdregtest for
the
crash in 0.45c1.There is only a hang remaining when debug is off.
Kind regards,Sylvain Petreolle
De : Thomas Faber thomas.fa...@reactos.org
À : ReactOS Development List ros-dev@reactos.org
Envoyé le : Jeudi 30 octobre 2014 14h51
Objet : Re: [ros-dev] BuildBot changes
On 2014-10
Hey,
On 2014-10-31 10:22, akha...@svn.reactos.org wrote:
@@ -90,6 +91,7 @@
//Invalid parameter detected
if (AllocAndLoadString(lpIllegalMsg,
GetModuleHandle(NULL), IDS_ILLEGAL_PARAM))
_putts(lpIllegalMsg);
+
On 2014-11-01 11:02, pschweit...@svn.reactos.org wrote:
-OutputBuffer-FileRecordLength = FileRecord-BytesInUse;
-RtlCopyMemory(OutputBuffer-FileRecordBuffer, FileRecord,
FileRecord-BytesInUse);
+OutputBuffer-FileRecordLength = DeviceExt-NtfsInfo.BytesPerFileRecord;
+
On 2014-11-01 11:13, Thomas Faber wrote:
On 2014-11-01 11:02, pschweit...@svn.reactos.org wrote:
-OutputBuffer-FileRecordLength = FileRecord-BytesInUse;
-RtlCopyMemory(OutputBuffer-FileRecordBuffer, FileRecord,
FileRecord-BytesInUse);
+OutputBuffer-FileRecordLength = DeviceExt
Hmm, my thought behind disabling this was more that this one test
doesn't justify increasing our whole test run time by 10%.
On 2014-11-11 11:12, spetreo...@svn.reactos.org wrote:
Author: spetreolle
Date: Tue Nov 11 16:12:14 2014
New Revision: 65378
URL:
On 2014-11-15 13:34, dquint...@svn.reactos.org wrote:
[SHELL32]
* Commit the folder location fixes. They are mostly untested due to being
unable to boot to desktop, but looking at the contents of the HDD after
syssetup runs seems that the shortcuts are all created in their rightful place.
If
On 2014-12-06 08:43, drei...@svn.reactos.org wrote:
[OSK]
Fix german layout by moving the # button where it should be and adding the button
next to Y
Erm... hard-coding keyboard layouts into OSK is a broken design by the
way. It should determine the current layout from the OS and display
On 2014-12-23 20:05, jimta...@svn.reactos.org wrote:
@@ -732,6 +732,7 @@
return NULL;
}
+ RtlZeroMemory(Message, sizeof(Message));
RtlMoveMemory(Message-Msg, Msg, sizeof(MSG));
return Message;
You mean sizeof(*Message)
On 2014-11-22 23:13, hbelu...@svn.reactos.org wrote:
+Status = NtCreateEvent(Console-InputBuffer.ActiveEvent,
EVENT_ALL_ACCESS,
+ ObjectAttributes, NotificationEvent, FALSE);
+if (!NT_SUCCESS(Status))
+{
+return STATUS_UNSUCCESSFUL;
+//
On 2014-12-28 11:05, pschweit...@svn.reactos.org wrote:
+extern ERESOURCE IopSecurityResource;
This resource is only ever acquired shared, meaning it doesn't provide
any mutual exclusion at all. Is that intentional?
___
Ros-dev mailing list
On 2015-02-07 16:26, hbelu...@svn.reactos.org wrote:
@@ -792,24 +791,54 @@
case UserThreadInitiateShutdown:
{
ERR(Shutdown initiated\n);
-STUB;
-Status = STATUS_NOT_IMPLEMENTED;
+
+if (ThreadInformationLength !=
On 2015-02-13 00:35, hbelu...@svn.reactos.org wrote:
+if (LSData-Session-UserToken != NULL
+!ImpersonateLoggedOnUser(LSData-Session-UserToken))
+{
+ERR(ImpersonateLoggedOnUser() failed with error %lu\n,
GetLastError());
+return 0;
+}
+
+/* Attempt
On 2015-01-25 16:57, jimta...@svn.reactos.org wrote:
-if (*HitTest == HTNOWHERE) *HitTest = HTCLIENT;
+ if (*HitTest == HTNOWHERE pwndChild == NULL) *HitTest = HTCLIENT;
pwndChild cannot be non-NULL here.
___
Ros-dev mailing list
On 2014-12-15 22:07, hbelu...@svn.reactos.org wrote:
+1 stub -noname ShellGetUserList ; (long long long)
For future reference, you might as well write this kind of thing as
1 stdcall -stub -noname ShellGetUserList(long long long)
Then spec2def will create a stub that uses the correct calling
On Sun, Feb 8, 2015 at 12:37 AM, Thomas Faber thomas.fa...@reactos.org
wrote:
On 2015-02-07 16:26, hbelu...@svn.reactos.org wrote:
@@ -792,24 +791,54 @@
case UserThreadInitiateShutdown:
{
ERR(Shutdown initiated\n);
-STUB;
-Status
: https://jira.reactos.org/browse/ROSTESTS-153
Project: ReactOS Test Suite
Issue Type: Bug
Components: Wine Tests
Reporter: Thomas Faber
Assignee: Bug Zilla
Labels: HACK
If you close this task, that means the winetest_interactive
On 2015-03-10 11:10, akha...@svn.reactos.org wrote:
+if(NOT MSVC)
+add_target_compile_flags(advapi32_winetest -Wno-format)
+endif()
Why are we getting format warnings? Is __WINESRC__ not set correctly?
___
Ros-dev mailing list
On 2015-03-10 12:02, Amine Khaldi wrote:
Why are we getting format warnings? Is __WINESRC__ not set correctly?
Hmm, it didn't help.
Ah, PROCESS_ALL_ACCESS is the problem. We have access right constants
defined with -L suffix. So yeah I think -Wno-format is the right
solution for now.
On 2015-03-10 01:09, tkreu...@svn.reactos.org wrote:
--- trunk/reactos/include/xdk/exfuncs.h [iso-8859-1] (original)
+++ trunk/reactos/include/xdk/exfuncs.h [iso-8859-1] Tue Mar 10
00:09:20 2015
@@ -606,14 +606,14 @@
VOID
NTAPI
ExFreePool(
- _In_ __drv_freesMem(Mem) PVOID
I don't see how creating a new host-tool is an improvement over using OS
builtins?
On 2015-03-29 03:53, hbelu...@svn.reactos.org wrote:
Author: hbelusca
Date: Sun Mar 29 01:53:10 2015
New Revision: 66946
URL: http://svn.reactos.org/svn/reactos?rev=66946view=rev
Log:
[CMAKE]
Improve the
On 2015-03-31 07:33, Thomas Faber wrote:
On 2015-03-31 00:50, gadamopou...@svn.reactos.org wrote:
--- trunk/reactos/dll/win32/browseui/CProgressDialog.cpp [iso-8859-1]
(original)
+++ trunk/reactos/dll/win32/browseui/CProgressDialog.cpp [iso-8859-1]
Mon Mar 30 22:50:34 2015
On 2015-03-31 00:50, gadamopou...@svn.reactos.org wrote:
--- trunk/reactos/dll/win32/browseui/CProgressDialog.cpp [iso-8859-1]
(original)
+++ trunk/reactos/dll/win32/browseui/CProgressDialog.cpp [iso-8859-1]
Mon Mar 30 22:50:34 2015
CProgressDialog::CProgressDialog()
{
+
Hey Timo,
I was just about to sync enhmetafile.c with Wine and found that your
original import had the following diff:
--- win32ss/gdi/gdi32/wine/enhmetafile.c(revision 67001)
+++ win32ss/gdi/gdi32/wine/enhmetafile.c(working copy)
@@ -546,8 +546,6 @@
if
On 2015-03-02 20:27, cwitt...@svn.reactos.org wrote:
--- trunk/reactos/include/psdk/wlanapi.h [iso-8859-1] (original)
+++ trunk/reactos/include/psdk/wlanapi.h [iso-8859-1] Mon Mar 2
19:27:45 2015
@@ -24,7 +24,7 @@
wlan_opcode_value_type_set_by_group_policy,
Broken tests is what they are.
For the most part, anyway.
On 2015-03-02 02:37, Hermès BÉLUSCA - MAÏTO wrote:
Hi! That's very nice! I'm however wondering what all those failed (or
crashed) tests are...
Hermès.
-Message d'origine-
De : Ros-dev [mailto:ros-dev-boun...@reactos.org]
Hmm what's the point of this? If it doesn't break anything, let's not
create a ROS-diff?
On 2015-03-02 02:15, hbelu...@svn.reactos.org wrote:
Author: hbelusca
Date: Mon Mar 2 01:15:00 2015
New Revision: 66538
URL: http://svn.reactos.org/svn/reactos?rev=66538view=rev
Log:
[SHLWAPI]:
I don't care about the reason.
Tests that fail on Windows are broken, period. In this order the tests
fail on Windows.
On 2015-02-26 09:38, jimta...@svn.reactos.org wrote:
Author: jimtabor
Date: Thu Feb 26 08:38:00 2015
New Revision: 66464
URL:
1 - 100 of 231 matches
Mail list logo
