Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

2018-02-11 Thread M. Ziggyesque
My 2 cents, I'd think it better specfies the hex values are BugCheck codes, not another error number set's values. That it's being output to the debug console is indication enough to most it's a System Error. :-) I'd keep "Fatal " before it to keep the emphasis it isn't considered recoverable,

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

2018-02-08 Thread Pierre Schweitzer
Done with e26e4445b39d7455e83e45ac7272d21289cc5106. Le 08/02/2018 à 11:29, Thomas Faber a écrit : > On 2018-02-08 01:55, Alex Ionescu wrote: >> This changes documented/external behavior. What is the point of this >> change? > > Hmm. Before approving the change I googled/tested whether Windows >

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

2018-02-08 Thread Thomas Faber
On 2018-02-08 01:55, Alex Ionescu wrote: This changes documented/external behavior. What is the point of this change? Hmm. Before approving the change I googled/tested whether Windows produces that output but somehow didn't see it. Now that you mention it, all versions of Windows do seem to

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

2018-02-08 Thread Pierre Schweitzer
Hey Alex, The root cause of this is: https://jira.reactos.org/browse/CORE-14293?focusedCommentId=101589=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-101589 Cheers, Pierre Le 08/02/2018 à 01:55, Alex Ionescu a écrit : > This changes documented/external behavior.

Re: [ros-dev] [ros-diffs] 01/01: [NTOS:KE] Replace "Fatal System Error" with "BugCheck"

2018-02-07 Thread Alex Ionescu
This changes documented/external behavior. What is the point of this change? Best regards, Alex Ionescu On Wed, Feb 7, 2018 at 1:22 PM, Serge Gautherie wrote: > https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6ece4e9fc22d664ea2485d04303e8ae10047f21f