Re: [ros-dev] ReactOS/Wine patches. BOOLs and the art of motorcycle repair.

2014-11-20 Thread Love Nystrom 
Wow.. (still) a touchy subject, by the number of reactions (no pun 
intended).


On 2014-11-14 22.45, Sylvain Petreolle wrote:

We already submit fixes to Wine.
Since Wine is upstream, patches are sent to Wine first.


Ah.. So it's already done. Bless your heart :)


I didn't 'reject' your patch blindly.


I didn't think you did.. honestly. I understood you had a reason.
But my attempt at "removing wine code" from that patch must have seemed 
feeble :/
After viewing the readme file, I felt like "OMG, I'll have to write a 
new utility just to

check that anything I patch don't stray into the hands-off list." Ugh.


There is also a change into shlwapi and freetype, which is 3rd party.
Changes to 3rd party code give silent reverts or conflicts at update 
time, better be safe than sorry.


I can understand that sentiment..
And I guess you can understand how overwhelming the "hands off" list is 
for an occasional contributor.
Has anyone out there already written (in C/C++) any tools that could be 
used to ease this?



@David 

What you suggest is that those developers who donate their time for 
the project should also take on the task of reviewing Wine changes, 
and sending patches to them, instead of letting the original author of 
the patch send it to the Wine patch review system directly, which 
already has their own set of volunteers.


No, that's not what meant at all..
I simply meant that if I sit with a nine headed hydra of a code, and Joe 
Small hands in a patch
that seeps into code I handle anyway, I could simply post it upstream 
with my own edits next time.

And .. According to Sylvain it's already done.

I understand that submitting patches to wine can be complicated 
sometimes,


That's got to be the understatement of the century ;)

Just to get into the right perspective, perhaps I should introduce myself..
I'm 57 years old and have been writing in C (and Assembly) since some 
time before IBM made their first PC.

Not that I think you made mistaken assumptions :)

I'm not saying that patches belonging to Wine components should 
automatically be discarded, 


I think @Mario said it well..
Review is something that always requires someone experienced *in the 
area*. Otherwise, it's kind of worthless.
Even if it's made by someone talented, we need someone who is 
recognized as such by Wine devs.



@Aleksey 
=



"Do you volunteer? :-)"


I'll trade you...
You figure out what's wrong with the wonky USB CDC in Arduino's  ATm32u4 
series,

that defeats the port notification mechanism in the Windows USB CDC driver,
making it only send generic raw USB device notifications, not ports..
Nah.. Just kidding :)

On a more serious note, I think Wine probably hate my guts, and would rather
see me dangle from a pine branch than accept a patch, even if I supplied
1000 lines of proof of my point.
Well.. perhaps not?

Exqueeze the OT, it's late and my brain's turned to mush :P


@Timo 
==



Getting patches into wine is kinda ... a PITA.


You can say that again.

If we have code that is *definately* broken. And potentially easy to 
get into wine, then it makes sense to invest the time to get it into 
there.


I agree with that.. had it been just a few patches. But put it in 
perspective of this BOOL case..
Patching 400 locations in 190 files of someone elses code may be all in 
a days work for some of you,
but for me it's kinda nerve wracking, and quite simply I was more 
concerned to not make a mistake
than taking even more time to wander the vast unknown arena of "hands 
off" and what not...

I'm sure you can understand that..

I wouldn't want to invest the time to get this into wine, for reasons 
of ... experience :)


You can say that again ;)
Pick the raisins from the cake then.. :P


@David 
===



To me it's a matter of readability/semantics.


My sentiment too.


@Eric 
===


I think @Timo said it well..
Most win32 APIs that return BOOL are described in MSDN with something 
like:

"If the function succeeds, the return value is *nonzero*."
And there are Windows APIs that return BOOL with values other than 0 
and 1.

And @Rafal, who observes..
The problem exists if we assign value obtained from bit operators e.g. 
"BOOLEAN HasFlag = a & SOME_FLAG"



Best Regards
// Love




*De :* Love Nystrom 
*À :* ReactOS Development List 
*Envoyé le :* Vendredi 14 novembre 2014 12h56
*Objet :* [ros-dev] ReactOS/Wine patches.

@Sylvain,

It occurred to me that since we have a lot of Wine code in ReactOS,
there will often be cases where ReactOS patches target Wine code.

Re: [ros-dev] ReactOS/Wine patches.

2014-11-15 Thread Timo Kreuzer 


Well said.

Getting patches into wine is kinda ... a PITA.
If we have code that is *definately* broken. And potentially easy to get 
into wine, then it makes sense to invest the time to get it into there.
For some coding style things that are most likely not bugs (until proven 
otherwise), I don't see the need to do that.
I appreaciate the efford to help to make our code less error prone. But 
when it comes to wine, I suggest patches be directly sent to wine by the 
original author.
I wouldn't want to invest the time to get this into wine, for reasons of 
... experience :)


Timo

Am 14.11.2014 17:39, schrieb David Quintana (gigaherz):

(I wrote this 3 hours ago but forgot to send)

Hello, I'm not Sylvain, but I want to make a note regardless.

Keep in mind that almost all the developers are contributors that work 
in their spare time. What you suggest is that those developers who 
donate their time for the project should also take on the task of 
reviewing Wine changes, and sending patches to them, instead of 
letting the original author of the patch send it to the Wine patch 
review system directly, which already has their own set of volunteers.


I understand that submitting patches to wine can be complicated 
sometimes, but they DO have places where the more veteran developers 
can help contributors with patches, before they attempt submitting 
them for review/commit. So "forcing" the ReactOS developers to do this 
work is redundant, and -- in my opinion -- also rude.


I'm not saying that patches belonging to Wine components should 
automatically be discarded, as that would be rude toward the author of 
the patch, and I see your point that it may be slightly faster if he 
patches come from a known contributor, I just want to make it very 
clear that since I'm one of the very few people that receives money 
from working on ReactOS (not sure if I'm the only one at the moment), 
when you ask one of the devs to do work that you could do yourself, 
chances are you are asking another volunteer, not a paid employee.



On 14 November 2014 12:56, Love Nystrom > wrote:


@Sylvain,

It occurred to me that since we have a lot of Wine code in ReactOS,
there will often be cases where ReactOS patches target Wine code.

Instead of just rejecting those patches, which is likely to make them
never see the light of day, the ReactOS programmers who maintain
our Wine code could act as liaisons, and review/post them to Wine.

I think that would make it more likely that Wine will commit those
patches in a timely fashion, since they are likely to know our
liaisons,
and we would gain by a faster turnaround on fixes in Wine code.

What do You think?

Best Regards
// Love


___
Ros-dev mailing list
[email protected] 
http://www.reactos.org/mailman/listinfo/ros-dev




___
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev


___
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] ReactOS/Wine patches.

2014-11-14 Thread Mario J. Rugiero 
In defense of the topic starter, review is something that always 
requires someone experienced in the area. Otherwise, it's kind of 
worthless. Even if it's made by someone talented, we need someone who is 
recognized as such by Wine devs.


Regards,
Mario.

___
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] ReactOS/Wine patches.

2014-11-14 Thread Aleksey Bragin 
I'm not Sylvain either, and since David revived this thread, the reply 
which I wanted to send to the topic starter was:


"Do you volunteer? :-)"

Regards,
Aleksey

On 14.11.2014 19:39, David Quintana (gigaherz) wrote:

(I wrote this 3 hours ago but forgot to send)

Hello, I'm not Sylvain, but I want to make a note regardless.

Keep in mind that almost all the developers are contributors that work 
in their spare time. What you suggest is that those developers who 
donate their time for the project should also take on the task of 
reviewing Wine changes, and sending patches to them, instead of 
letting the original author of the patch send it to the Wine patch 
review system directly, which already has their own set of volunteers.


I understand that submitting patches to wine can be complicated 
sometimes, but they DO have places where the more veteran developers 
can help contributors with patches, before they attempt submitting 
them for review/commit. So "forcing" the ReactOS developers to do this 
work is redundant, and -- in my opinion -- also rude.


I'm not saying that patches belonging to Wine components should 
automatically be discarded, as that would be rude toward the author of 
the patch, and I see your point that it may be slightly faster if he 
patches come from a known contributor, I just want to make it very 
clear that since I'm one of the very few people that receives money 
from working on ReactOS (not sure if I'm the only one at the moment), 
when you ask one of the devs to do work that you could do yourself, 
chances are you are asking another volunteer, not a paid employee.



On 14 November 2014 12:56, Love Nystrom > wrote:


@Sylvain,

It occurred to me that since we have a lot of Wine code in ReactOS,
there will often be cases where ReactOS patches target Wine code.

Instead of just rejecting those patches, which is likely to make them
never see the light of day, the ReactOS programmers who maintain
our Wine code could act as liaisons, and review/post them to Wine.

I think that would make it more likely that Wine will commit those
patches in a timely fashion, since they are likely to know our
liaisons,
and we would gain by a faster turnaround on fixes in Wine code.

What do You think?

Best Regards
// Love



___
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] ReactOS/Wine patches.

2014-11-14 Thread David Quintana (gigaherz) 
(I wrote this 3 hours ago but forgot to send)

Hello, I'm not Sylvain, but I want to make a note regardless.

Keep in mind that almost all the developers are contributors that work in
their spare time. What you suggest is that those developers who donate
their time for the project should also take on the task of reviewing Wine
changes, and sending patches to them, instead of letting the original
author of the patch send it to the Wine patch review system directly, which
already has their own set of volunteers.

I understand that submitting patches to wine can be complicated sometimes,
but they DO have places where the more veteran developers can help
contributors with patches, before they attempt submitting them for
review/commit. So "forcing" the ReactOS developers to do this work is
redundant, and -- in my opinion -- also rude.

I'm not saying that patches belonging to Wine components should
automatically be discarded, as that would be rude toward the author of the
patch, and I see your point that it may be slightly faster if he patches
come from a known contributor, I just want to make it very clear that since
I'm one of the very few people that receives money from working on ReactOS
(not sure if I'm the only one at the moment), when you ask one of the devs
to do work that you could do yourself, chances are you are asking another
volunteer, not a paid employee.


On 14 November 2014 12:56, Love Nystrom  wrote:

> @Sylvain,
>
> It occurred to me that since we have a lot of Wine code in ReactOS,
> there will often be cases where ReactOS patches target Wine code.
>
> Instead of just rejecting those patches, which is likely to make them
> never see the light of day, the ReactOS programmers who maintain
> our Wine code could act as liaisons, and review/post them to Wine.
>
> I think that would make it more likely that Wine will commit those
> patches in a timely fashion, since they are likely to know our liaisons,
> and we would gain by a faster turnaround on fixes in Wine code.
>
> What do You think?
>
> Best Regards
> // Love
>
>
> ___
> Ros-dev mailing list
> [email protected]
> http://www.reactos.org/mailman/listinfo/ros-dev
>
___
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] ReactOS/Wine patches.

2014-11-14 Thread Sylvain Petreolle 
We already submit fixes to Wine.Since Wine is upstream, patches are sent to 
Wine first.I didn't 'reject' your patch blindly. There is also a change into 
shlwapi and freetype, which is 3rd party.
Changes to 3rd party code give silent reverts or conflicts at update time, 
better be safe than sorry.See [reactos] Revision 57747 and [#CORE-6495] 
unicode: some CLI Programs compiled and using unicode outputs characters 
incorrectly. - ReactOS JIRA for an example of these.


|   |
|   |  |   |   |   |   |   |
| [reactos] Revision 57747 |
|  |
| Afficher sur svn.reactos.org | Aperçu par Yahoo |
|  |
|   |



|   |
|   |  |   |   |   |   |   |
| [#CORE-6495] unicode: some CLI Programs compiled and usi...I have noticed on 
CLI (Command Line Interface) programs that have been compiled using UNICODE 
displays junk characters between each intended character.  |
|  |
| Afficher sur jira.reactos.org | Aperçu par Yahoo |
|  |
|   |

  Kind regards,Sylvain Petreolle
  De : Love Nystrom 
 À : ReactOS Development List  
 Envoyé le : Vendredi 14 novembre 2014 12h56
 Objet : [ros-dev] ReactOS/Wine patches.
   
@Sylvain,

It occurred to me that since we have a lot of Wine code in ReactOS,
there will often be cases where ReactOS patches target Wine code.

Instead of just rejecting those patches, which is likely to make them
never see the light of day, the ReactOS programmers who maintain
our Wine code could act as liaisons, and review/post them to Wine.

I think that would make it more likely that Wine will commit those
patches in a timely fashion, since they are likely to know our liaisons,
and we would gain by a faster turnaround on fixes in Wine code.

What do You think?



Best Regards
// Love


___
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev


  ___
Ros-dev mailing list
[email protected]
http://www.reactos.org/mailman/listinfo/ros-dev