Re: [Rosegarden-devel] Update on tuplet rewrite

2013-12-05 Thread D. Michael McIntyre
Interesting. I didn't see that. Maybe I should collect all the observations, then have a closer look. It appears there might be several issues that need some attention. A code review might uncover them pretty quickly. I never use the keyboard for anything ever, and I go way back, so

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-12-04 Thread Tom Breton (Tehom)
I was also slowed down by the mouse not working very well for placing notes. Is this a known issue? Or am I doing this wrong? Hmm, I wasn't sure what mouse behavior you were talking about, so I tried placing notes with mouse. Is it something like this?: At first, clicking to place notes

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-12-04 Thread Ted Felix
On 12/04/2013 12:11 PM, Tom Breton (Tehom) wrote: Is it something like this?: At first, clicking to place notes works fine. At some point you deselect, and then even though the draw tool is selected, mouse clicks don't do anything. You select the draw tool again, and it works again. No,

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-12-04 Thread Ted Felix
On 12/04/2013 07:53 AM, D. Michael McIntyre wrote: On 12/03/2013 10:21 PM, Ted Felix wrote: (Monitor isn't shutting off in specific subtle situations.) No it isn't, and IT'S PISSING ME OFF! You too? I'm digging through gnome-screensaver right now (C and GLib and D-Bus, oh my!), but I'm

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-12-03 Thread Ted Felix
On 12/03/2013 06:22 PM, Tom Breton (Tehom) wrote: It's also more bulletproof, I hope. * Handles slivers, ie notes that go just barely across a barline or other metric line. * Handles truncated bars, ie where some time-signature has started a new bar prematurely. * Almost

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-22 Thread Tom Breton (Tehom)
Note for the record that addressing these particular problems isn't what Tom is trying to accomplish. He's working on inserting/editing tuplets, not importing tuplets from MIDI. I was just trying to see if I could use the new stuff to get around these other problems, and I sort of can, 2/3

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-17 Thread D. Michael McIntyre
I'm having another go with spanish_ballad.mid after building the latest changes. For those who don't know, the recurring pattern in this file is bars consisting of three voices in one polyphonic part: 4 4 4 8 8 8 8 8 8 8 8 8 1 The most obvious difference is that the whole notes on

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-17 Thread Aere Greenway
On 11/17/2013 06:43 PM, D. Michael McIntyre wrote: So now the big problem that remains with this file is that all those 8 8 8 groups are triplets, but they're only partially represented as such. The durations and tupled/untupled nonsense are all right, but they're not in tuplet groups. I

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-17 Thread D. Michael McIntyre
On 11/17/2013 11:29 PM, Aere Greenway wrote: I think it would be that way if the time-signature is 6/8 time. Good thought, but I already tried that idea. 1) Even with this recurring rhythmic pattern, every one of numerous sources is in complete agreement that the piece is in 3/4. 2) Changing

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-16 Thread Chris Cannam
On Fri, Nov 15, 2013, at 10:05 PM, D. Michael McIntyre wrote: On 11/15/2013 04:40 PM, Chris Cannam wrote: released, most probably, but if it *just* gets merged and released without really being exercised, it won't work. I agree, though it's a problematic situation in that I just never

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-16 Thread Ted Felix
On 11/16/2013 05:08 AM, Chris Cannam wrote: You should definitely mess around with it even if you never venture outside your most familiar workflow. I was thinking of looking for some snippets to use as test cases. Can anyone recommend specific pieces or composers that would be

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-16 Thread Tom Breton (Tehom)
On 11/16/2013 05:08 AM, Chris Cannam wrote: You should definitely mess around with it even if you never venture outside your most familiar workflow. I was thinking of looking for some snippets to use as test cases. Can anyone recommend specific pieces or composers that would be

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-16 Thread Ted Felix
On 11/16/2013 02:21 PM, Tom Breton (Tehom) wrote: Just to throw some public domain examples out there Perfect. I'll grab the ones you recommend and see about putting them on a wiki page for reference. Hopefully that will get the ball rolling. Ted.

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-16 Thread Tom Breton (Tehom)
On 11/16/2013 02:21 PM, Tom Breton (Tehom) wrote: Just to throw some public domain examples out there Perfect. I'll grab the ones you recommend and see about putting them on a wiki page for reference. Hopefully that will get the ball rolling. Well, not 100% perfect. I forgot that

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-15 Thread Chris Cannam
On Fri, Nov 15, 2013, at 09:50 AM, Chris Cannam wrote: Rebuilding once more without debug (btw I had already confirmed the crash -- without debug -- on a build from clean) Chris -- DreamFactory - Open Source REST

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-15 Thread Chris Cannam
OK, here's what I did: * build rev 13554 from clean without debug * open the Ravel example piece * select just the right hand segment, open in notation editor * find the very first 12-tupleted note in the part * select that note only * hit the delete key on the keyboard Program received

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-15 Thread Chris Cannam
On Fri, Nov 15, 2013, at 10:30 AM, Chris Cannam wrote: Program received signal SIGFPE, Arithmetic exception. 0x00539eaf in Rosegarden::TimeSignature::setInternalDurations() And here's valgrind: ==7241== Process terminating with default action of signal 8 (SIGFPE) ==7241== Integer

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-15 Thread D. Michael McIntyre
On 11/14/2013 12:27 PM, Tom Breton (Tehom) wrote: I understand. Can't set your own schedule; people need their fuel oil. When you are able to, I'd appreciate comments. Gasoline, mostly. Damn cars. So all I did was swat at it on the run, but I finally got it built. I'll look more deeply

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-15 Thread Chris Cannam
On Fri, Nov 15, 2013, at 06:27 PM, Tom Breton (Tehom) wrote: Possible approaches: * Roll that part back. Much as I hate to just give up, it's causing Chris's crashes and this weirdness, and it was really just supposed to be an optimization and minimize what got rewritten. That is

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-15 Thread Tom Breton (Tehom)
2) I continued flailing around deleting things haphazardly. I never got a crash, but if you start deleting a bunch of random notes from the 12-tuplet groups, you eventually wind up with random triplet rests scattered around, and nothing indicating that the remaining notes are 12 or any other

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-15 Thread Tom Breton (Tehom)
I will fix that as well. Probably I'll set that count sensibly after a file is loaded. It was more surprising than that. RoseXmlHandler already has code to remap segment ID counts. It's just done at the wrong time. It was done as soon as an event was seen, before it has properties, so of

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-14 Thread D. Michael McIntyre
On 11/13/2013 08:56 PM, Tom Breton (Tehom) wrote: OK, I have rewritten the tuplet rewrite so it handles the Ravel example, keeping the 6-lets. Still haven't had a moment to check the damn branch out and play with it. I want to. -- D. Michael McIntyre

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-14 Thread Chris Cannam
On Thu, Nov 14, 2013, at 01:56 AM, Tom Breton (Tehom) wrote: OK, I have rewritten the tuplet rewrite so it handles the Ravel example, keeping the 6-lets. Also, as Chris wanted, I have made it handle dirty subunits of a bar instead of always doing a while bar. I was only going to do this

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-14 Thread Tom Breton (Tehom)
On 11/13/2013 08:56 PM, Tom Breton (Tehom) wrote: OK, I have rewritten the tuplet rewrite so it handles the Ravel example, keeping the 6-lets. Still haven't had a moment to check the damn branch out and play with it. I want to. I understand. Can't set your own schedule; people need

Re: [Rosegarden-devel] Update on tuplet rewrite

2013-11-14 Thread Tom Breton (Tehom)
Hm, now if I delete one of the 12-tuplets (or try to insert a shorter note over the top) it crashes with an FPE. That's odd. I can't reproduce it. Deleted 12-lets, deleted 12-leted groups, inserted 12-lets, deleted 32nds, nothing crashed. Can you give me a more detailed recipe for

[Rosegarden-devel] Update on tuplet rewrite

2013-11-13 Thread Tom Breton (Tehom)
OK, I have rewritten the tuplet rewrite so it handles the Ravel example, keeping the 6-lets. Also, as Chris wanted, I have made it handle dirty subunits of a bar instead of always doing a while bar. I was only going to do this if needed for performance, but since its absence was felt, I went