[Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Guillaume Laurent
Can anyone bring me up to date on the current status of the guitar-related code ? I'm looking into it right now and it seems to be missing some bits (it refers to some rc files, guitar.rc fretboardinserter.rc, some classes aren't used anywhere - GuitarTabEditorWindow), and I can't find a way to

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Stephen Torri
On Sat, 2006-07-29 at 12:26 +0200, Guillaume Laurent wrote: Can anyone bring me up to date on the current status of the guitar-related code ? I'm looking into it right now and it seems to be missing some bits (it refers to some rc files, guitar.rc fretboardinserter.rc, some classes aren't

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Stephen Torri
On Sat, 2006-07-29 at 20:09 +0200, Pedro Lopez-Cabanillas wrote: I think that there is a bug: the chord diagrams aren't drawn over the notehead you clicked, but one or two beats after it. How you suggest I get the position of where to play the diagram? At present I try to calculate the

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Pedro Lopez-Cabanillas
On Saturday, 29 July 2006 20:25, Stephen Torri wrote: On Sat, 2006-07-29 at 20:09 +0200, Pedro Lopez-Cabanillas wrote: I think that there is a bug: the chord diagrams aren't drawn over the notehead you clicked, but one or two beats after it. How you suggest I get the position of where to

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread D. Michael 'Silvan' McIntyre
On Saturday 29 July 2006 3:01 pm, Pedro Lopez-Cabanillas wrote: I think that there is nothing wrong in this code fragment. You are calculating the insertionTime correctly, and you can see in the event list editor that your fingering events have the right times. The problem must be at the

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Stephen Torri
On Sat, 2006-07-29 at 20:19 +0200, Guillaume Laurent wrote: On Saturday 29 July 2006 19:05, Stephen Torri wrote: I am working on the next generation of the guitar chord. What you see at present is a prototype which is going to be radically changed. The present prototype allows the user to

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread D. Michael McIntyre
On Saturday 29 July 2006 2:19 pm, Guillaume Laurent wrote: That's Michelle, right ? I wish she had replied to my request to provide a patch using standard tools :-). Me too. -- D. Michael 'Silvan' McIntyre Silvan [EMAIL PROTECTED] Linux fanatic, and certified Geek; registered Linux

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Pedro Lopez-Cabanillas
On Saturday, 29 July 2006 21:01, I wrote: The problem must be at the rendering part, I guess. I've committed a patch trying to fix this issue. First, the Event constructor at Fingering::getAsEvent() was wrong (it needs four arguments). It now sets the sub-ordering property to -60 as you

Re: [Rosegarden-devel] status of the guitar code ?

2006-07-29 Thread Stephen Torri
On Sun, 2006-07-30 at 03:35 +0200, Pedro Lopez-Cabanillas wrote: On Saturday, 29 July 2006 21:01, I wrote: The problem must be at the rendering part, I guess. I've committed a patch trying to fix this issue. First, the Event constructor at Fingering::getAsEvent() was wrong (it needs four