Re: [Rosegarden-devel] Excessive construction/destruction of ViewElements
On 4/7/22 5:51 AM, Ted Felix wrote: I'm hoping that at some point you'll have some time to work the magic you've done for the editors on the main window (CompositionView). It's super-slow after recording for an hour. And I suspect some of the lessons you've learned in the editors can be applied there. That (slowdown) sounds scary (to debug). Somewhere down the road let's look into it. It's called "software". 🤣 Yes . I've had experience with that phenomenon. ;) And that's fine. Since you are working this way, you should probably drop the multiple branches and merge requests and just work in a "mark" branch. I can follow along with that and bring it over into the official rosegarden repo to make it easier for everyone to test as well. The bug/feature request numbers in the commit messages tell the whole story. A single branch seems like it's more your style, so that should be more productive for you. It's up to you. I can handle whatever is thrown at me git-wise. Sounds good. I'll get my latest code to a stable point and move in the direction you suggest. I just want to make sure you'll be able to pull out a rational series of incremental commits if and when they're merged into master. (Thinking about bisection in the future.) Having a branch in the main repo would be great for getting some pre-merge testing. I'll name it "thanks4opensrc" to protect my superhero secret identity. ;) ___ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
Re: [Rosegarden-devel] Excessive construction/destruction of ViewElements
On 4/7/22 4:15 AM, mark_at_yahoo via Rosegarden-devel wrote: On 4/6/22 4:09 PM, Ted Felix wrote: On 4/6/22 5:30 PM, mark_at_yahoo via Rosegarden-devel wrote: But as I've written before, I'm an optimization freak It's one of my specialties as well. So I'm really glad you are looking into all this. Thanks for the encouragement, Ted. I'm hoping that at some point you'll have some time to work the magic you've done for the editors on the main window (CompositionView). It's super-slow after recording for an hour. And I suspect some of the lessons you've learned in the editors can be applied there. So what you're saying is that Rosegarden is a gothic horror that lures unsuspecting coders into an infinite purgatory of improving a Frankenstein monster that will never be truly finished? ;) It's called "software". 🤣 Not a problem. I just wanted to know that my code will eventually be reviewed for possible inclusion. Absolutely. When you do get around to it, lets coordinate and I can try to refactor the commits into some kind of logical linear progression of merges. This would be ideal, but I really need to get my head around some of your early commits so I can provide some useful feedback. I'm really close to finishing 1624. Just need to find some more time. I'll try to write with that in mind, but the one good thing is that I'll be running the build from the head of my "all changes combined" branch and hopefully will catch and fix the inevitable bugs there. And that's fine. Since you are working this way, you should probably drop the multiple branches and merge requests and just work in a "mark" branch. I can follow along with that and bring it over into the official rosegarden repo to make it easier for everyone to test as well. The bug/feature request numbers in the commit messages tell the whole story. A single branch seems like it's more your style, so that should be more productive for you. It's up to you. I can handle whatever is thrown at me git-wise. Ted. ___ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
Re: [Rosegarden-devel] Excessive construction/destruction of ViewElements
On 4/6/22 4:09 PM, Ted Felix wrote: On 4/6/22 5:30 PM, mark_at_yahoo via Rosegarden-devel wrote: But as I've written before, I'm an optimization freak It's one of my specialties as well. So I'm really glad you are looking into all this. Thanks for the encouragement, Ted. I took a quick glance at adding a set of referencing ViewElements to the Event class and while I was afraid that would require patching in lots of places it might actually be much simpler. Maybe just in the base ViewElement constructor, but even if not there's only NotationElement and MatrixElement that derive from it. I'll look further, and at other/alternate approaches. Note that I never planned on doing this kind of deep surgery on the RG code. I came here to fix one bug and implement one feature, yet in doing so I keep falling deeper and deeper down the rabbit hole. That's exactly how I ended up here. Now you're scaring me. ;) I've read your bio on the "authors" page. Coming up on 12 years now, right? So what you're saying is that Rosegarden is a gothic horror that lures unsuspecting coders into an infinite purgatory of improving a Frankenstein monster that will never be truly finished? ;) And I obviously understand that there's a good chance anything I do (including the merge requests I've already submitted) will end up living forever only in my own repository fork. Yeah, sorry about that. I will do my best to bring your changes in, but it is going to take some time. There is a lot going on these days. Not a problem. I just wanted to know that my code will eventually be reviewed for possible inclusion. If it wasn't going to be I could just go back to simpler hacking on my own. (When they're only going to affect me personally I'm much more nonchalant about potential bugs.) When you do get around to it, lets coordinate and I can try to refactor the commits into some kind of logical linear progression of merges. I'll try to write with that in mind, but the one good thing is that I'll be running the build from the head of my "all changes combined" branch and hopefully will catch and fix the inevitable bugs there. ___ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
Re: [Rosegarden-devel] Excessive construction/destruction of ViewElements
On 4/6/22 5:30 PM, mark_at_yahoo via Rosegarden-devel wrote: Note: This post is going to make me even less popular with the Rosegarden developer community than I already am. No judgment. I'm just glad you are looking at these things and doing something about it. There are a lot of problems all throughout rg. It's not surprising that you've found some. But as I've written before, I'm an optimization freak It's one of my specialties as well. So I'm really glad you are looking into all this. Note that I never planned on doing this kind of deep surgery on the RG code. I came here to fix one bug and implement one feature, yet in doing so I keep falling deeper and deeper down the rabbit hole. That's exactly how I ended up here. And I obviously understand that there's a good chance anything I do (including the merge requests I've already submitted) will end up living forever only in my own repository fork. Yeah, sorry about that. I will do my best to bring your changes in, but it is going to take some time. There is a lot going on these days. Ted. ___ Rosegarden-devel mailing list Rosegarden-devel@lists.sourceforge.net - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
