Re: [Rosegarden-user] File Locking

2016-04-12 Thread Al Thompson
On 04/12/2016 10:52 AM, D. Michael McIntyre wrote: > Why not a button to clear the lock ? > I thought about that, but it seems too tempting to invite users to just > click away a problem instead of taking the time to investigate and deal > with it. Couldn't you have a .rg file on a shared

Re: [Rosegarden-user] File Locking

2016-04-12 Thread D. Michael McIntyre
On 04/12/2016 10:17 AM, Yves Guillemot wrote: >> contents of some pixels on the screen in a dialog is obnoxious when you >> have to clear a lock file after a crash. >> > Why not a button to clear the lock ? I thought about that, but it seems too tempting to invite users to just click away a

Re: [Rosegarden-user] File Locking

2016-04-12 Thread Yves Guillemot
Le mardi 12 avril 2016, 08:57:35 D. Michael McIntyre a écrit : > I finally figured out what this is missing. The file location text > needs to be in some kind of selectable area, so you can grab the text > straight out of the dialog. Navigating to the file based on the > contents of some pixels

Re: [Rosegarden-user] File Locking

2016-04-06 Thread Yves Guillemot
Le mardi 5 avril 2016, 21:56:48 Ted Felix a écrit : >This should be fixed as of [r14586]. Works fine here. Yves -- ___ Rosegarden-user mailing list

Re: [Rosegarden-user] File Locking

2016-04-06 Thread Yves Guillemot
Le mercredi 6 avril 2016, 06:02:18 D. Michael McIntyre a écrit : > On 04/05/2016 10:54 PM, Ted Felix wrote: > > I'm testing with diacritics in Ubuntu with no trouble. The lock file > > > > name in the message box matches the lock filename exactly. No UTF-8 > > garbage. Is this a

Re: [Rosegarden-user] File Locking

2016-04-06 Thread D. Michael McIntyre
On 04/05/2016 10:54 PM, Ted Felix wrote: > I'm testing with diacritics in Ubuntu with no trouble. The lock file > name in the message box matches the lock filename exactly. No UTF-8 > garbage. Is this a distro-related problem? Or am I testing with the > wrong diacritics? My test file is

Re: [Rosegarden-user] File Locking

2016-04-05 Thread Ted Felix
On 03/31/2016 09:45 AM, Yves Guillemot wrote: > There is a small issue (repeatedly occurring with RG) about UTF8 garbage in > the displayed lock file name when the .rg file uses non ASCII characters (I > did > the first test with a file name containing a diacritic). I'm testing with

Re: [Rosegarden-user] File Locking

2016-04-05 Thread Ted Felix
On 03/31/2016 09:45 AM, Yves Guillemot wrote: > Then I tried a less obvious case: > > - Create a new composition in RG and save it in a file. Keep RG open. > - Create again a new composition in another RG instance > - Try to save the last composition in the same file as fhe first one. > =>

Re: [Rosegarden-user] File Locking

2016-04-01 Thread D. Michael McIntyre
On 03/31/2016 08:08 PM, Ted Felix wrote: > I'll leave it up to you. Feel free to tweak the message text too. I > don't anticipate any further changes near those areas, so conflicts are > unlikely. I WILL have a look, I just don't know what month quite yet. -- D. Michael McIntyre

Re: [Rosegarden-user] File Locking

2016-04-01 Thread Abrolag
On Fri, 1 Apr 2016 06:33:11 -0400 Ted Felix wrote: > On 04/01/2016 03:49 AM, Kevin Donnelly wrote: > > The only thing I'd suggest is that it might be handy to give the > > location of the lock file. > >Absolutely. It's actually in there. I just removed it to focus the

Re: [Rosegarden-user] File Locking

2016-04-01 Thread Kevin Donnelly
Hi Ted On 31/03/16 21:00, Ted Felix wrote: > How about this: "Could not lock file. Another user or instance of > Rosegarden may already be editing this file. If you are sure no one > else is editing this file, delete the lock file and try again." The only thing I'd suggest is that it might be

Re: [Rosegarden-user] File Locking

2016-03-31 Thread D. Michael McIntyre
On 03/31/2016 05:34 PM, Yves Guillemot wrote: >> OK, I figured somebody would find something like this. Is there >> something we can do about this? > > Usually QString::fromStdString() does the conversion. Meant to mention I'll be happy to fiddle with that part of it if you don't get it

Re: [Rosegarden-user] File Locking

2016-03-31 Thread Yves Guillemot
Le jeudi 31 mars 2016, 16:00:12 Ted Felix a écrit : > >How about this: > > "Could not lock file. Another user or instance of Rosegarden may > already be editing this file. If you are sure no one else is editing > this file, delete the lock file and try again." > Seems very good to me.

Re: [Rosegarden-user] File Locking

2016-03-31 Thread Yves Guillemot
Le jeudi 31 mars 2016, 15:53:23 Ted Felix a écrit : > On 03/31/2016 09:45 AM, Yves Guillemot wrote: > > the displayed lock file name when the .rg file uses non ASCII characters > > (I did the first test with a file name containing a diacritic). > >OK, I figured somebody would find something

Re: [Rosegarden-user] File Locking

2016-03-31 Thread Ted Felix
On 03/31/2016 09:45 AM, Yves Guillemot wrote: > An other (very) small problem is the "Could not lock file" message which may > be > unclear for some users. > An improvment should be to add in the popup a first sentence explaining that > two different RG instances try to access the same file.

Re: [Rosegarden-user] File Locking

2016-03-31 Thread Ted Felix
On 03/31/2016 09:45 AM, Yves Guillemot wrote: > Then I tried a less obvious case: Thanks for finding that. I'll have a look. > There is a small issue (repeatedly occurring with RG) about UTF8 garbage in > the displayed lock file name when the .rg file uses non ASCII characters (I > did >

Re: [Rosegarden-user] File Locking

2016-03-31 Thread Yves Guillemot
Le mercredi 30 mars 2016, 23:03:12 Ted Felix a écrit : >Just finished implementing file locking (see bug #1510) to prevent > having a file open in two instances of rg. I would appreciate any > testing anyone can do. >The obvious test case to see the new behavior is to launch rg twice >